Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-82836: Parse service version #122

Merged
merged 7 commits into from
Sep 2, 2021
Merged

CLOUDP-82836: Parse service version #122

merged 7 commits into from
Sep 2, 2021

Conversation

fmenezes
Copy link
Contributor

@fmenezes fmenezes commented Sep 1, 2021 •
edited
Loading

Proposed changes

Parse service version header X-MongoDB-Service-Version

Jira ticket: CLOUDP-82836

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

⚠️ this change depends on mongodb/go-client-mongodb-atlas#248 ⚠️

@fmenezes fmenezes requested a review from a team as a code owner September 1, 2021 16:48
@fmenezes fmenezes requested review from andreaangiolillo and removed request for a team September 1, 2021 16:48
@fmenezes fmenezes mentioned this pull request Sep 1, 2021
Merged
5 tasks
colm-quinn
colm-quinn previously approved these changes Sep 2, 2021
View reviewed changes
Copy link
Collaborator

@colm-quinn colm-quinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fmenezes fmenezes requested a review from colm-quinn September 2, 2021 12:27
@fmenezes fmenezes dismissed colm-quinn’s stale review September 2, 2021 12:29

I've changed the code again

@fmenezes fmenezes removed the request for review from andreaangiolillo September 2, 2021 12:29
gssbzn
gssbzn reviewed Sep 2, 2021
View reviewed changes
opsmngr/opsmngr.go Outdated Show resolved Hide resolved
@fmenezes
Copy link
Contributor Author

fmenezes commented Sep 2, 2021

@gssbzn ready for another look

gssbzn
gssbzn approved these changes Sep 2, 2021
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the tests

colm-quinn
colm-quinn approved these changes Sep 2, 2021
View reviewed changes
Copy link
Collaborator

@colm-quinn colm-quinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@fmenezes fmenezes merged commit 6c046e0 into master Sep 2, 2021
@fmenezes fmenezes deleted the CLOUDP-82836 branch September 2, 2021 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colm-quinn colm-quinn colm-quinn approved these changes

@gssbzn gssbzn gssbzn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fmenezes @gssbzn @colm-quinn