Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INTMDB-545!: add Azure support to cloudProviderAccess #507

Merged
merged 4 commits into from
Jul 21, 2023
Merged

INTMDB-545!: add Azure support to cloudProviderAccess #507

merged 4 commits into from
Jul 21, 2023

Conversation

andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented Jul 21, 2023 •
edited by gssbzn
Loading

Description

Ticket: INTMDB-545

This PR adds Azure support to cloudProviderAccess.

BREAKING CHANGE: Renamed AWSIAMRole to IAMRole

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@andreaangiolillo andreaangiolillo requested a review from a team as a code owner July 21, 2023 08:01
wtrocki
wtrocki reviewed Jul 21, 2023
View reviewed changes
mongodbatlas/cloud_provider_access.go
RoleID string `json:"roleId,omitempty"` // Unique ID of this role.
RoleID string `json:"roleId,omitempty"` // Unique 24-hexadecimal digit string that identifies the role.
ID *string `json:"_id,omitempty"` // Unique 24-hexadecimal digit string that identifies the Azure Service Principal in Atlas.
AtlasAzureAppID *string `json:"atlasAzureAppId,omitempty"` // Azure Active Directory Application ID of Atlas.
Copy link
Member

@wtrocki wtrocki Jul 21, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Can we change the order of properties to make it easier to understand what comes from which polymorphic type? For example: Putting ID as first property or adding an Azure prefix in the comments

Copy link
Collaborator Author

@andreaangiolillo andreaangiolillo Jul 21, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to make sure I understood the suggestion here: you are proposing to update the description of each field and add Azure:desciption or AWS: description? What about the fields that are needed with both? Azure|AWS:description?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no strong opinion on this.
My suggestion was to add prefixes to Azure: specific properties. Adding AWS ones could be a bonus.
Otherwise no description update is needed.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@andreaangiolillo andreaangiolillo changed the title INTMDB-545: add Azure support to cloudProviderAccess INTMDB-545!: add Azure support to cloudProviderAccess Jul 21, 2023
wtrocki
wtrocki previously approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@wtrocki wtrocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We need to update release notes. Small comment to improve clarity

@gssbzn gssbzn added the breaking Pull requests that breaks backwards compatibility label Jul 21, 2023
gssbzn
gssbzn reviewed Jul 21, 2023
View reviewed changes
mongodbatlas/cloud_provider_access.go Outdated
Comment on lines 46 to 47
// IAMRole is the response from the CloudProviderAccessService.ListRoles.
type IAMRole struct {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about

Suggested change
// IAMRole is the response from the CloudProviderAccessService.ListRoles.
type IAMRole struct {
// CloudProviderAccessRole is the response from the CloudProviderAccessService.ListRoles.
type CloudProviderAccessRole struct {

so it matches CloudProviderAccessRoleRequest

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

wtrocki
wtrocki approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@wtrocki wtrocki left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome change! Thank you

gssbzn
gssbzn approved these changes Jul 21, 2023
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@andreaangiolillo andreaangiolillo merged commit 97c98b2 into master Jul 21, 2023
@andreaangiolillo andreaangiolillo deleted the INTMDB-545 branch July 21, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wtrocki wtrocki wtrocki approved these changes

@gssbzn gssbzn gssbzn approved these changes

Assignees
No one assigned
Labels
breaking Pull requests that breaks backwards compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andreaangiolillo @gssbzn @wtrocki