Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INTMDB-137: Fix output of CloudProviderAccessService.GetRole #500

Merged
merged 4 commits into from
Jun 19, 2023
Merged

INTMDB-137: Fix output of CloudProviderAccessService.GetRole #500

merged 4 commits into from
Jun 19, 2023

Conversation

andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented Jun 19, 2023 •
edited
Loading

Description

CloudProviderAccessService.GetRole returns AWSIAMRole instead of an array as the Open API spec suggests. Fixing the Open API spec in #76871

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@andreaangiolillo andreaangiolillo changed the title INTMDB-137: fix INTMDB-137: Fix output of CloudProviderAccessService.GetRole Jun 19, 2023
@andreaangiolillo andreaangiolillo marked this pull request as ready for review June 19, 2023 07:52
@andreaangiolillo andreaangiolillo requested a review from a team as a code owner June 19, 2023 07:52
@andreaangiolillo andreaangiolillo merged commit d69ad1a into master Jun 19, 2023
@andreaangiolillo andreaangiolillo deleted the INTMDB-137_fix branch June 19, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tibulca tibulca tibulca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreaangiolillo @tibulca