Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-179719 v0.28.0 pre-release #492

Merged
merged 1 commit into from
May 29, 2023
Merged

CLOUDP-179719 v0.28.0 pre-release #492

merged 1 commit into from
May 29, 2023

Conversation

fmenezes
Copy link
Contributor

@fmenezes fmenezes commented May 29, 2023 •
edited
Loading

Description

Releasing SDK to contain tags field on serverless instances apis

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@fmenezes fmenezes marked this pull request as ready for review May 29, 2023 16:06
@fmenezes fmenezes requested a review from a team as a code owner May 29, 2023 16:06
andreaangiolillo
andreaangiolillo reviewed May 29, 2023
View reviewed changes
CHANGELOG.md
@@ -1,5 +1,13 @@
# Changelog

## [v0.28.0](https://github.com/mongodb/go-client-mongodb-atlas/tree/v0.28.0) (May 29, 2023)
Copy link
Collaborator

@andreaangiolillo andreaangiolillo May 29, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a question for my own learning that isn't directly linked to this PR: I noticed we've added a new feature to our manual SDK. I thought our plan was to transition towards using the autogenerated SDK with the CLI. Could you clarify why we added this feature to the manually built SDK instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clusters are still using old SDK as of today

@fmenezes fmenezes requested a review from andreaangiolillo May 29, 2023 16:18
andreaangiolillo
andreaangiolillo approved these changes May 29, 2023
View reviewed changes
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fmenezes fmenezes merged commit f3df93d into master May 29, 2023
@fmenezes fmenezes deleted the CLOUDP-179719 branch May 29, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreaangiolillo andreaangiolillo andreaangiolillo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fmenezes @andreaangiolillo