Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDP-141434: Add RootCertType to the atlas go client #319

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented Oct 24, 2022

Description

The cluster struct is missing the RootCertType parameter. (API)

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@andreaangiolillo andreaangiolillo requested a review from a team as a code owner October 24, 2022 08:20
@andreaangiolillo andreaangiolillo requested review from themantissa and removed request for a team October 24, 2022 08:20
@andreaangiolillo
Copy link
Collaborator Author

Looking at the codebase, RootCertType is an enum that can have the value ISRGROOTX1 and DST but while trying to create a cluster with RootCertType: DST I got the error:

{
  "detail" : "Cannot switch to use DST certificates in Atlas clusters.",
  "error" : 400,
  "errorCode" : "DST_ROOT_CERT_UNSUPPORTED",
  "parameters" : [ ],
  "reason" : "Bad Request"
}%

I am closing this PR since the only value allowed for RootCertType is ISRGROOTX1

@gssbzn gssbzn reopened this Oct 24, 2022
@andreaangiolillo
Copy link
Collaborator Author

FYI: Reopened the PR since we still want to show the field when retrieved

@andreaangiolillo
Copy link
Collaborator Author

FYI: you cannot set RootCertType as ""

{
  "detail" : "An invalid enumeration value  was specified.",
  "error" : 400,
  "errorCode" : "INVALID_ENUM_VALUE",
  "parameters" : [ "" ],
  "reason" : "Bad Request"
}

@andreaangiolillo andreaangiolillo merged commit 1bf5c9a into master Oct 24, 2022
@andreaangiolillo andreaangiolillo deleted the CLOUDP-141434 branch October 24, 2022 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants