Update to Go v1.18 #308
Merged
Update to Go v1.18 #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -136,3 +135,4 @@ linters: | |||
| # - wastedassign # wastedassign finds wasted assignment statements. [fast: false, auto-fix: false] | |||
| # - wrapcheck # Checks that errors returned from external packages are wrapped [fast: false, auto-fix: false] | |||
| # - wsl # Whitespace Linter - Forces you to use empty lines! [fast: true, auto-fix: false] | |||
| # - ifshort # Checks that your code uses short syntax for if-statements whenever possible [fast: true, auto-fix: false] | |||
There was a problem hiding this comment.
this lint has been deprecated
andreaangiolillo
requested review from
blva and
gssbzn
and removed request for
a team
blva
previously approved these changes
Aug 16, 2022
mongodbatlas/doc.go
Outdated
| @@ -33,7 +33,7 @@ pass cancellation signals and deadlines to various services of the client for | |||
| handling a request. In case there is no context available, then context.Background() | |||
| can be used as a starting point. | |||
|
|
|||
| Authentication | |||
| Authentication. | |||
There was a problem hiding this comment.
yes, the lint test was failing because of this
There was a problem hiding this comment.
I think this is a bit odd. For example, we don't need the dot in line 18. Could you share the rule that requires this? Wondering if we can remove it/search if it's a bug/try to tweak the text to not require this...
There was a problem hiding this comment.
you are right. I will try to remove it
blva
approved these changes
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the fix/feature/change, including any relevant motivation and context.
Link to any related issue(s):
Type of change:
Required Checklist:
make fmtand formatted my codeFurther comments