Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

task: drop support for whitelist #306

Merged
merged 1 commit into from
Aug 9, 2022
Merged

task: drop support for whitelist #306

merged 1 commit into from
Aug 9, 2022

Conversation

gssbzn
Copy link
Collaborator

@gssbzn gssbzn commented Aug 8, 2022

Description

Please include a summary of the fix/feature/change, including any relevant motivation and context.

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

We were keeping whitelists mainly for ops manager compatibility with 4.4, 4.4 is now EoL we can clean this up

@gssbzn gssbzn added the breaking Pull requests that breaks backwards compatibility label Aug 8, 2022
@gssbzn gssbzn requested a review from a team as a code owner August 8, 2022 11:26
@gssbzn gssbzn requested review from themantissa and removed request for a team August 8, 2022 11:26
themantissa
themantissa approved these changes Aug 8, 2022
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, glad you remembered to remove this. Gone from Terraform and CloudFormation so good on my side. Thank you for checking!

@gssbzn gssbzn merged commit 25681b6 into master Aug 9, 2022
@gssbzn gssbzn deleted the rm-whitelist branch August 9, 2022 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themantissa themantissa themantissa approved these changes

Assignees
No one assigned
Labels
breaking Pull requests that breaks backwards compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gssbzn @themantissa