Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-127482: Add filter by name on list all groups by org #302

Merged
merged 1 commit into from
Jul 1, 2022
Merged

CLOUDP-127482: Add filter by name on list all groups by org #302

merged 1 commit into from
Jul 1, 2022

Conversation

fmenezes
Copy link
Contributor

@fmenezes fmenezes commented Jul 1, 2022

Description

Add filter by name on list all groups by org

Link to any related issue(s): CLOUDP-127482

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@fmenezes fmenezes requested a review from a team as a code owner July 1, 2022 10:00
@gssbzn gssbzn added the breaking Pull requests that breaks backwards compatibility label Jul 1, 2022
gssbzn
gssbzn approved these changes Jul 1, 2022
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gssbzn gssbzn requested review from themantissa and a team July 1, 2022 10:05
@fmenezes fmenezes marked this pull request as draft July 1, 2022 10:16
@fmenezes fmenezes marked this pull request as ready for review July 1, 2022 10:16
evertsd
evertsd approved these changes Jul 1, 2022
View reviewed changes
Copy link
Collaborator

@evertsd evertsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I see no cause for concern on the terraform-provider-mongodbatlas side with regards to this being a potentially breaking change.

@fmenezes fmenezes merged commit 4e47ff2 into master Jul 1, 2022
@fmenezes fmenezes deleted the CLOUDP-127482 branch July 1, 2022 12:59
@gssbzn gssbzn mentioned this pull request Mar 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evertsd evertsd evertsd approved these changes

@gssbzn gssbzn gssbzn approved these changes

@themantissa themantissa Awaiting requested review from themantissa

Assignees
No one assigned
Labels
breaking Pull requests that breaks backwards compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fmenezes @gssbzn @evertsd