INTMDB-301: Feature add: Add support for management of federated authentication configuration #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return nil, NewArgError("federationSettingsID", "must be set") | ||
| } | ||
|
|
||
| basePath := fmt.Sprintf(federationSettingsOrganizationConnectionBasePath, federationSettingsID, orgID) |
| @@ -0,0 +1,157 @@ | |||
| // Copyright 2019 MongoDB Inc | |||
There was a problem hiding this comment.
Suggested change
| // Copyright 2019 MongoDB Inc | |
| // Copyright 2022 MongoDB Inc |
| @@ -0,0 +1,76 @@ | |||
| // Copyright 2019 MongoDB Inc | |||
There was a problem hiding this comment.
Suggested change
| // Copyright 2019 MongoDB Inc | |
| // Copyright 2022 MongoDB Inc |
martinstibbe
changed the title
|
@gssbzn is there anyone else on the team that can review this while Andrea is out on vacation? |
gssbzn
reviewed
May 26, 2022
gssbzn
requested changes
May 26, 2022
gssbzn
reviewed
May 26, 2022
mongodbatlas/federation_settings.go
Outdated
| Get(context.Context, string) (*FederatedSettings, *Response, error) | ||
| Delete(context.Context, string) (*Response, error) | ||
| ListConnectedOrgs(context.Context, *ListOptions, string) (*FederatedSettingsConnectedOrganizations, *Response, error) | ||
| GetConnectedOrgs(context.Context, string, string) (*FederatedSettingsConnectedOrganization, *Response, error) |
There was a problem hiding this comment.
Suggested change
| GetConnectedOrgs(context.Context, string, string) (*FederatedSettingsConnectedOrganization, *Response, error) | |
| GetConnectedOrg(context.Context, string, string) (*FederatedSettingsConnectedOrganization, *Response, error) |
gssbzn
reviewed
May 26, 2022
mongodbatlas/federation_settings.go
Outdated
| UpdateRoleMapping(context.Context, string, string, string, *FederatedSettingsOrganizationRoleMapping) (*FederatedSettingsOrganizationRoleMapping, *Response, error) | ||
| DeleteRoleMapping(context.Context, string, string, string) (*Response, error) | ||
|
|
||
| ListIdentityProvider(context.Context, *ListOptions, string) ([]FederatedSettingsIdentityProvider, *Response, error) |
There was a problem hiding this comment.
Suggested change
| ListIdentityProvider(context.Context, *ListOptions, string) ([]FederatedSettingsIdentityProvider, *Response, error) | |
| ListIdentityProviders(context.Context, *ListOptions, string) ([]FederatedSettingsIdentityProvider, *Response, error) |
There was a problem hiding this comment.
Refactored to ListIdentityProviders(context.Context, string, *ListOptions) ([]FederatedSettingsIdentityProvider, *Response, error)
gssbzn
reviewed
May 27, 2022
gssbzn
reviewed
May 27, 2022
gssbzn
reviewed
May 27, 2022
gssbzn
reviewed
May 27, 2022
Co-authored-by: Gustavo Bazan <[email protected]>
gssbzn
approved these changes
May 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for managment of federated authentication configuration
Link to any related issue(s):
https://jira.mongodb.org/browse/INTMDB-301
Type of change:
Required Checklist:
make fmtand formatted my codeFurther comments