Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INTMDB-311: Feature Add: Prometheus and Microsoft Team to the Third Party Integration Settings #284

Merged
merged 2 commits into from
Apr 4, 2022
Merged

INTMDB-311: Feature Add: Prometheus and Microsoft Team to the Third Party Integration Settings #284

merged 2 commits into from
Apr 4, 2022

Conversation

martinstibbe
Copy link
Collaborator

@martinstibbe martinstibbe commented Mar 30, 2022 •
edited
Loading

Description

Feature Add: Prometheus and Microsoft Team to the Third Party Integration Settings

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@martinstibbe martinstibbe requested a review from a team as a code owner March 30, 2022 02:37
andreaangiolillo
andreaangiolillo reviewed Mar 30, 2022
View reviewed changes
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these properties! I have just a few comments.

mongodbatlas/third_party_integration.go Outdated
Password string `json:"password,omitempty"`
ServiceDiscovery string `json:"serviceDiscovery,omitempty"`
Scheme string `json:"scheme,omitempty"`
Enabled string `json:"enabled,omitempty"`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enabled is a boolean

mongodbatlas/third_party_integration.go
OrgName string `json:"orgName,omitempty"`
URL string `json:"url,omitempty"`
Secret string `json:"secret,omitempty"`
Type string `json:"type,omitempty"`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the unit test to use these new properties?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expanded tests to cover Teams and Prometheus feature added

andreaangiolillo
andreaangiolillo approved these changes Apr 4, 2022
View reviewed changes
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for addressing all the comments! 💯

@martinstibbe martinstibbe merged commit 8f6da9f into master Apr 4, 2022
@martinstibbe martinstibbe deleted the INTMDB-311 branch April 4, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreaangiolillo andreaangiolillo andreaangiolillo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinstibbe @andreaangiolillo