Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTMDB-299: Added snapshot export jobs support #279

Merged
merged 3 commits into from
Feb 15, 2022

Conversation

abner-dou
Copy link
Contributor

Description

Added support for CloudProviderSnapshotExportJobs

Link to any related issue(s): INTMDB-299

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@abner-dou abner-dou requested a review from a team as a code owner February 14, 2022 21:33
@abner-dou abner-dou requested review from johansteyn and removed request for a team February 14, 2022 21:33
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small things to fix

ExportStatus *CloudProviderSnapshotExportJobStatus `json:"exportStatus,omitempty"` // Returned for replica set only. Status of the export job.
FinishedAt string `json:"finishedAt,omitempty"` // Timestamp in ISO 8601 date and time format in UTC when the export job completes.
Prefix string `json:"prefix,omitempty"` // Full path on the cloud provider bucket to the folder where the snapshot is exported. The path is in the following format: /exported_snapshots/{ORG-NAME}/{PROJECT-NAME}/{CLUSTER-NAME}/{SNAPSHOT-INITIATION-DATE}/{TIMESTAMP}
SnapshotID string `json:"snapshotID,omitempty"` // Unique identifier of the snapshot.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
SnapshotID string `json:"snapshotID,omitempty"` // Unique identifier of the snapshot.
SnapshotID string `json:"snapshotId,omitempty"` // Unique identifier of the snapshot.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed :)

@abner-dou abner-dou requested a review from gssbzn February 15, 2022 16:54
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gssbzn gssbzn merged commit 4b760c3 into mongodb:master Feb 15, 2022
@abner-dou abner-dou deleted the INTMDB-299-jobs branch February 15, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants