INTMDB-299: Added snapshot export bucket support #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gssbzn
reviewed
Feb 1, 2022
gssbzn
reviewed
Feb 1, 2022
| // CloudProviderSnapshotExportBucket represents one cloud provider snapshot export buckets. | ||
| type CloudProviderSnapshotExportBucket struct { | ||
| ID string `json:"_id,omitempty"` // Unique identifier of the S3 bucket. | ||
| ProjectID string `json:"projectId,omitempty"` // Unique 24-hexadecimal digit string identifying the project. |
There was a problem hiding this comment.
[q] this is only documented for the create, but even so the example doesn't use it, is this really necessary?
There was a problem hiding this comment.
I can remove it, but I don't know if the end users will need it, due it's in the create documentation.
There was a problem hiding this comment.
if you have tested the curls and it does actually show or is needed we keep it, I'm just wondering if this is a documentation error, not a blocker to keep
thetonymaster
approved these changes
Feb 1, 2022
|
@gssbzn @thetonymaster can you merge this please |
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added snapshot export buckets support
Link to any related issue(s): INTMDB-299
Type of change:
Required Checklist:
make fmtand formatted my codeFurther comments