Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INTMDB-270: Added 'withDefaultAlertsSettings' property to Project struct #265

Merged
merged 1 commit into from
Nov 3, 2021
Merged

INTMDB-270: Added 'withDefaultAlertsSettings' property to Project struct #265

merged 1 commit into from
Nov 3, 2021

Conversation

abner-dou
Copy link
Contributor

@abner-dou abner-dou commented Nov 3, 2021 •
edited
Loading

Description

Added a new property withDefaultAlertsSettings to Project struct to enable/disable default settings on create project

Link to any related issue(s): INTMDB-270

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@abner-dou abner-dou requested a review from a team as a code owner November 3, 2021 16:37
@abner-dou abner-dou requested review from threebee and removed request for a team November 3, 2021 16:37
@abner-dou abner-dou changed the title \4568DZBV'dded to Project struct INTMDB-270: Added 'withDefaultAlertsSettings' property to Project struct Nov 3, 2021
gssbzn
gssbzn approved these changes Nov 3, 2021
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gssbzn gssbzn merged commit 77290cf into mongodb:master Nov 3, 2021
@abner-dou abner-dou deleted the INTMDB-270 branch November 3, 2021 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gssbzn gssbzn gssbzn approved these changes

@threebee threebee Awaiting requested review from threebee threebee was automatically assigned from mongodb/apix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abner-dou @gssbzn