Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ GA Fast Follows #3147

Merged
merged 2 commits into from
Jan 8, 2024
Merged

C++ GA Fast Follows #3147

merged 2 commits into from
Jan 8, 2024

Conversation

dacharyc
Copy link
Collaborator

@dacharyc dacharyc commented Jan 8, 2024

Pull Request Info

This ticket incorporates a few outstanding review comments from #3140, and it updates the unit test suites to use the release version - v1.0.0.

  • CRUD/Filter Data: Update the note about supporting a subset of RQL and make it an include.
  • Sync Data/Manage Sync Subscriptions: Add the note about C++ supporting a subset of RQL to the section about subscribing to objects that match a query.
  • Realm Files: Add ToC to the blank container page in case someone navigates to it.

Review Guidelines

REVIEWING.md

Copy link

github-actions bot commented Jan 8, 2024

Readability for Commit Hash: d15411f

You can see any previous Readability scores (if they exist) by looking
at the comment's history.

Readability scores for changed documents:

  • source/sdk/cpp/realm-files: Grade Level: 5.6, Reading Ease: 65.39
  • source/sdk/cpp/sync/sync-subscriptions: Grade Level: 7.1, Reading Ease: 66.94
  • source/sdk/cpp/crud/filter-data: Grade Level: 8.7, Reading Ease: 57.37

For Grade Level, aim for 8 or below.

For Reading Ease scores, aim for 60 or above:

Score Difficulty
90-100 Very Easy
80-89 Easy
70-79 Fairly Easy
60-69 Medium
50-59 Fairly Hard
30-49 Hard
0-29 Very Hard

For help improving readability, try Hemingway App.

@dacharyc dacharyc merged commit c7a44f5 into mongodb:master Jan 8, 2024
8 checks passed
@dacharyc dacharyc deleted the cpp-ga-fast-follows branch January 8, 2024 20:53
@docs-builder-bot
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants