(DOCSP-35187): C++: Update Google Auth examples for v0.6.0 #3136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dacharyc
changed the title
|
Readability for Commit Hash: 11d0a4b You can see any previous Readability scores (if they exist) by looking Readability scores for changed documents:
For Grade Level, aim for 8 or below. For Reading Ease scores, aim for 60 or above:
For help improving readability, try Hemingway App. |
cbullinger
approved these changes
Jan 5, 2024
examples/cpp/sync/authentication.cpp
Outdated
| // // :snippet-end: | ||
| // } | ||
| void testSignInWithGoogleAuthCodeSyntax() { | ||
| auto myAuthCode = "some auth code string"; |
There was a problem hiding this comment.
Suggested change
| auto myAuthCode = "some auth code string"; | |
| // The user's server auth code you got from Google | |
| auto myAuthCode = "auth_code_from_google"; |
maybe include this in the snippet?
examples/cpp/sync/authentication.cpp
Outdated
| appConfig.app_id = APP_ID; | ||
| auto app = realm::App(appConfig); | ||
|
|
||
| // The auth_code below is the user's server auth code you got from Google |
There was a problem hiding this comment.
Suggested change
| // The auth_code below is the user's server auth code you got from Google |
(if we're including the above changes)
examples/cpp/sync/authentication.cpp
Outdated
| } | ||
|
|
||
| void testSignInWithGoogleIdTokenSyntax() { | ||
| auto myIdToken = "some ID token string"; |
There was a problem hiding this comment.
same
Suggested change
| auto myIdToken = "some ID token string"; | |
| // The user's OpenID Connect token you got from | |
| // the Google OAuth response | |
| auto myIdToken = "openid_connect_token"; |
examples/cpp/sync/authentication.cpp
Outdated
| appConfig.app_id = APP_ID; | ||
| auto app = realm::App(appConfig); | ||
|
|
||
| // The id_token below is the user's OpenID Connect id_token you got from |
There was a problem hiding this comment.
same
Suggested change
| // The id_token below is the user's OpenID Connect id_token you got from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
Jira ticket: https://jira.mongodb.org/browse/DOCSP-35187
Review Guidelines
REVIEWING.md