Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-45876 Add parallel operations callout #952

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

stephmarie17
Copy link
Collaborator

@stephmarie17 stephmarie17 commented Dec 17, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-45876
Staging - https://deploy-preview-952--docs-node.netlify.app/fundamentals/transactions/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link

netlify bot commented Dec 17, 2024

Deploy Preview for docs-node ready!

Name Link
🔨 Latest commit d9c4390
🔍 Latest deploy log https://app.netlify.com/sites/docs-node/deploys/6765de73b03391000842b632
😎 Deploy Preview https://deploy-preview-952--docs-node.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@norareidy norareidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a small suggestion!

source/fundamentals/transactions.txt Outdated Show resolved Hide resolved
source/fundamentals/transactions.txt Outdated Show resolved Hide resolved
@@ -208,6 +208,15 @@ the Convenient Transaction API:
To see a fully runnable example that uses this API, see the
:ref:`node-usage-convenient-txn` usage example.

.. sharedinclude:: dbx/transactions-parallelism.rst
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this joined with:

Parallel Operations Not Supported
The Node.js driver does not support running parallel operations within a single transaction.

It seems like a separate note to point folks at the client api for more than one namespace. Also, none of the driver support parallel operations in a transaction because it isn't supported on the server rather than there being a driver side limitation.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me check with the docs team on that, we pretty much got tickets for most of the drivers docs that have a transactions page to add this and organize it this way. But I'll link your comment and see what the feedback is!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants