Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-41823: autoSelectFamily and autoSelectFamilyAttemptTimeout options #944

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

mayaraman19
Copy link
Collaborator

@mayaraman19 mayaraman19 commented Dec 9, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-41823
Staging - https://deploy-preview-944--docs-node.netlify.app/fundamentals/connection/connection-options/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link

netlify bot commented Dec 9, 2024

👷 Deploy request for docs-node pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 2cae032

Copy link
Collaborator

@norareidy norareidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm + small suggestions

* - **autoSelectFamily**
- boolean
- ``true``
- If set to true, the socket attempts to connect to IPv6 and IPv4 addresses
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: I'd monospace the boolean value

Suggested change
- If set to true, the socket attempts to connect to IPv6 and IPv4 addresses
- If set to ``true``, the socket attempts to connect to IPv6 and IPv4 addresses

- Specifies the amount of time in milliseconds to wait for a connection
attempt to finish before trying the next address when using the
``autoSelectFamily`` option. If set to a positive integer less than ``10``,
the value ``10`` is used instead.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: reword to avoid passive voice, maybe:

Suggested change
the value ``10`` is used instead.
the driver resets this value to ``10``.

@mayaraman19 mayaraman19 merged commit 6d1bb81 into mongodb:master Dec 10, 2024
4 checks passed
@mayaraman19 mayaraman19 deleted the DOCSP-41823-fallback branch December 10, 2024 15:20
github-actions bot pushed a commit that referenced this pull request Dec 10, 2024
github-actions bot pushed a commit that referenced this pull request Dec 10, 2024
github-actions bot pushed a commit that referenced this pull request Dec 10, 2024
mayaraman19 pushed a commit that referenced this pull request Dec 10, 2024
mayaraman19 pushed a commit that referenced this pull request Dec 10, 2024
mayaraman19 pushed a commit that referenced this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants