Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-43243 Clarify driver support for language versions #943

Merged
merged 6 commits into from
Dec 10, 2024

Conversation

lindseymoore
Copy link
Collaborator

@lindseymoore lindseymoore commented Dec 5, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-43243
Staging - https://deploy-preview-943--docs-node.netlify.app/compatibility/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link

netlify bot commented Dec 5, 2024

Deploy Preview for docs-node ready!

Name Link
🔨 Latest commit 556d1c3
🔍 Latest deploy log https://app.netlify.com/sites/docs-node/deploys/6758a03bc341790008076b23
😎 Deploy Preview https://deploy-preview-943--docs-node.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@alexbevi alexbevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@mcmorisi mcmorisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some tweaks!

the {+driver-long+} for use with a specific version of Node.js.

The first column lists the driver version.

.. include:: /includes/language-compatibility-table-node.rst

.. note:: The {+driver-short+} Supports Node.js Versions in the "Active LTS" Phase or Later

After release, Node.js versions have a "Current" release status for six months
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: does "Current" need to be capitalized?

Copy link
Collaborator Author

@lindseymoore lindseymoore Dec 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capitalized it, as it is written in the Node.js docs: https://nodejs.org/en/about/previous-releases.

source/compatibility.txt Outdated Show resolved Hide resolved
source/compatibility.txt Outdated Show resolved Hide resolved
@lindseymoore lindseymoore merged commit f90a9a3 into mongodb:master Dec 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants