Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-38014 SSL Error Workaround #942

Merged
merged 7 commits into from
Dec 6, 2024

Conversation

lindseymoore
Copy link
Collaborator

@lindseymoore lindseymoore commented Dec 3, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-38014
Staging - https://deploy-preview-942--docs-node.netlify.app/fundamentals/connection/tls/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for docs-node ready!

Name Link
🔨 Latest commit 002abaf
🔍 Latest deploy log https://app.netlify.com/sites/docs-node/deploys/6752349408e68f00086ceb71
😎 Deploy Preview https://deploy-preview-942--docs-node.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

source/fundamentals/connection/tls.txt Outdated Show resolved Hide resolved
source/fundamentals/connection/tls.txt Outdated Show resolved Hide resolved
@lindseymoore lindseymoore requested a review from nbbeeken December 5, 2024 19:49
Copy link
Collaborator

@mongoKart mongoKart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👍

a few small things that i'm happy to talk more about

source/fundamentals/connection/tls.txt Outdated Show resolved Hide resolved
@@ -77,6 +77,26 @@ in the following ways:
see the :manual:`SRV Connection Format </reference/connection-string/#srv-connection-format>`
section in the Server manual.

.. note:: Workaround for an "unsafe legacy renegotiation disabled" error
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: is 'unsafe legacy renegotation disabled' the exact text in the error? is it capitalized there?

Copy link
Collaborator Author

@lindseymoore lindseymoore Dec 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is how the error is written in the ticket (uncapitalized) and online in forums. Added monospace in the text if that makes it clearer that this is the verbatim error. Let me know what you think!

source/fundamentals/connection/tls.txt Outdated Show resolved Hide resolved
source/fundamentals/connection/tls.txt Outdated Show resolved Hide resolved
source/fundamentals/connection/tls.txt Outdated Show resolved Hide resolved
"
"
""
"
"
Copy link
Collaborator

@mongoKart mongoKart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lindseymoore lindseymoore merged commit ca66d3e into mongodb:master Dec 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants