Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-45610 - v6.11 #937

Merged
merged 5 commits into from
Nov 25, 2024
Merged

DOCSP-45610 - v6.11 #937

merged 5 commits into from
Nov 25, 2024

Conversation

mongoKart
Copy link
Collaborator

@mongoKart mongoKart commented Nov 25, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-45610
Staging - https://deploy-preview-937--docs-node.netlify.app/whats-new/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for docs-node ready!

Name Link
🔨 Latest commit 04301ab
🔍 Latest deploy log https://app.netlify.com/sites/docs-node/deploys/6744c059ca6f640008d9be15
😎 Deploy Preview https://deploy-preview-937--docs-node.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@mcmorisi mcmorisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment on lines 54 to 56
to ``ENVIRONMENT:k8s`` in your connection string. You can use this feature when connecting
to an environment running in Amazon's EKS (Elastic Kubernetes Service), Google's GKE
(Google Kubernetes Engine), or Azure's AKS (Azure Kubernetes Service).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Not sure we need the initialisms if we're only naming these the one time

Suggested change
to ``ENVIRONMENT:k8s`` in your connection string. You can use this feature when connecting
to an environment running in Amazon's EKS (Elastic Kubernetes Service), Google's GKE
(Google Kubernetes Engine), or Azure's AKS (Azure Kubernetes Service).
to ``ENVIRONMENT:k8s`` in your connection string. You can use this feature when connecting
to an environment running in Amazon Elastic Kubernetes Service, Google Kubernetes Engine, or Azure Kubernetes Service.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call

Comment on lines +65 to +67
- The ``bson`` package adds support for binary vector data. To learn more about this feature,
see the :github:`v6.10.0 Release Notes <mongodb/js-bson/releases/tag/v6.10.0>` for the
``bson`` package on GitHub.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: Just confirming that bson is at version 6.10.0 compared to the driver itself being v6.11.0

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, thanks for checking

@mongoKart mongoKart merged commit 7422a87 into mongodb:master Nov 25, 2024
4 of 5 checks passed
@mongoKart mongoKart deleted the docsp-45610-v6.11 branch November 25, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants