Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-43242: Improve UTF-8 validation documentation to clarify validation occurs on decoded data only #908

Merged
merged 12 commits into from
Oct 14, 2024

Conversation

mayaraman19
Copy link
Collaborator

@mayaraman19 mayaraman19 commented Oct 9, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-43242
Staging - https://deploy-preview-908--docs-node.netlify.app/fundamentals/bson/utf8-validation/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link

netlify bot commented Oct 9, 2024

Deploy Preview for docs-node ready!

Name Link
🔨 Latest commit 7aabab3
🔍 Latest deploy log https://app.netlify.com/sites/docs-node/deploys/670d80687503350008eef729
😎 Deploy Preview https://deploy-preview-908--docs-node.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mayaraman19 mayaraman19 marked this pull request as ready for review October 10, 2024 14:58
Copy link
Collaborator

@jordan-smith721 jordan-smith721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion but otherwise LGTM!

source/fundamentals/bson/utf8-validation.txt Outdated Show resolved Hide resolved
@mayaraman19 mayaraman19 force-pushed the DOCSP-43242-improve-utf8 branch from 7439fa4 to 7a02764 Compare October 11, 2024 16:06
source/fundamentals/bson/utf8-validation.txt Outdated Show resolved Hide resolved
source/fundamentals/bson/utf8-validation.txt Outdated Show resolved Hide resolved
source/fundamentals/bson/utf8-validation.txt Outdated Show resolved Hide resolved
@mayaraman19 mayaraman19 requested a review from nbbeeken October 11, 2024 20:45
Copy link
Collaborator

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@jordan-smith721 jordan-smith721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion but otherwise LGTM!

source/fundamentals/bson/utf8-validation.txt Outdated Show resolved Hide resolved
@mayaraman19 mayaraman19 merged commit 2094a00 into mongodb:master Oct 14, 2024
5 checks passed
@mayaraman19 mayaraman19 deleted the DOCSP-43242-improve-utf8 branch October 14, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants