-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(DOCSP-32272): Atlas Top 250: Add Atlas to intro, provide Atlas-focused connection string #806
Conversation
61b8064
to
d85ae98
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of small suggestions, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I left a few suggestions that I think could help the consistency of the page.
@@ -17,8 +17,8 @@ Connection Guide | |||
:depth: 2 | |||
:class: singlecol | |||
|
|||
This guide shows you how to connect to a MongoDB instance or replica set | |||
using the Node.js driver. | |||
This guide shows you how to connect to a MongoDB Atlas instance, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion:
I think the terminology Atlas uses is "cluster" (see https://www.mongodb.com/docs/atlas/manage-clusters/)
This guide shows you how to connect to a MongoDB Atlas instance, | |
This guide shows you how to connect to a MongoDB Atlas cluster, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion:
I think the terminology Atlas uses is "cluster" (see https://www.mongodb.com/docs/atlas/manage-clusters/)
The term "cluster" actually doesn't include serverless instances, which can also connect via Node driver. If we want to use a term other than "instance," we could use "database deployment" or "deployment" as those are usually used in the Atlas docs to encompass both clusters and serverless
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll go with "deployment" here to encompass both cases. Thank you both for the suggestions/info!
the :manual:`Standard Connection String Format </reference/connection-string/#std-label-connections-standard-connection-string-format>`. | ||
|
||
If your instance or deployment has a DNS SRV record, you can use the | ||
In this example, we connect to an Atlas MongoDB deployment that has a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion:
I think "Atlas cluster" would be most recognizable given the prior suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the info that Sarah provided above, I think "deployment" covers both clusters and serverless, so I'll stick with that here unless there's a strong preference for something else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
…ed connection string (mongodb#806) * Add Atlas to intro, provide Atlas-focused connection string * Incorporate review feedback * Correct errors in facet usage
Pull Request Info
Note for reviewer: the rST has several build errors related to the facet directive, similar to:
Those errors are outside the scope of this PR. This PR's changes are free of warnings or errors in the rST.
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-32272
Staging - Connection Guide
Self-Review Checklist