docsp-32718 - add comments #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustagir
requested changes
Aug 31, 2023
| @@ -7,9 +7,12 @@ const client = new MongoClient(uri); | |||
|
|
|||
There was a problem hiding this comment.
Q: I thought we were supposed to add code comments for the import statement and client creation as well -- Up to you if you want to add to the files throughout this PR.
There was a problem hiding this comment.
I saw those in the chat gpt example, but thought they were more like "this is a stop sign" than anything substantial.
| const query = { "entries.x": { $type : "string" } }; | ||
|
|
||
| // For each matched element, increase value of y by 33 |
There was a problem hiding this comment.
I: I think this example only updates the first matching array element
Suggested change
| // For each matched element, increase value of y by 33 | |
| // For the first matched array entry, increase value of y by 33 |
Comment on lines
8
to
9
| async function run() { | ||
| try { |
There was a problem hiding this comment.
Q: for the Usage examples that have JS and TS versions, should we update both?
There was a problem hiding this comment.
Caitlin confirmed JS only
Co-authored-by: Rea Rustagi <[email protected]>
mongoKart
added a commit
that referenced
this pull request
Sep 5, 2023
(cherry picked from commit 11461c3)
mongoKart
added a commit
that referenced
this pull request
Sep 5, 2023
(cherry picked from commit 11461c3)
mongoKart
added a commit
that referenced
this pull request
Sep 5, 2023
(cherry picked from commit 11461c3)
mongoKart
added a commit
that referenced
this pull request
Sep 5, 2023
(cherry picked from commit 11461c3)
mongoKart
added a commit
that referenced
this pull request
Sep 5, 2023
(cherry picked from commit 11461c3)
mongoKart
added a commit
that referenced
this pull request
Sep 5, 2023
(cherry picked from commit 11461c3)
mongoKart
added a commit
that referenced
this pull request
Sep 5, 2023
(cherry picked from commit 11461c3)
mongoKart
added a commit
that referenced
this pull request
Sep 5, 2023
(cherry picked from commit 11461c3)
mongoKart
added a commit
to mongoKart/docs-node
that referenced
this pull request
Nov 3, 2023
caitlindavey
added a commit
that referenced
this pull request
Nov 26, 2024
* DOCSP-31824: Update page titles (#774) (cherry picked from commit 9cd60b1) * DOCSP-30081: Fix find to find() * docsp-32718 - add comments (#770) (cherry picked from commit 11461c3) * Added code comments (#772) (#778) (cherry picked from commit 5b0652a) * removed nested components * fixing bulkWrite * Fixing bulkwrite --------- Co-authored-by: Nora Reidy <[email protected]> Co-authored-by: Mike Woofter <[email protected]> Co-authored-by: Jordan Smith <[email protected]>
caitlindavey
added a commit
to caitlindavey/docs-node
that referenced
this pull request
Nov 26, 2024
* DOCSP-31824: Update page titles (mongodb#774) (cherry picked from commit 9cd60b1) * DOCSP-30081: Fix find to find() * docsp-32718 - add comments (mongodb#770) (cherry picked from commit 11461c3) * Added code comments (mongodb#772) (mongodb#778) (cherry picked from commit 5b0652a) * removed nested components * fixing bulkWrite * Fixing bulkwrite --------- Co-authored-by: Nora Reidy <[email protected]> Co-authored-by: Mike Woofter <[email protected]> Co-authored-by: Jordan Smith <[email protected]> (cherry picked from commit fa3f2bc)
caitlindavey
added a commit
that referenced
this pull request
Nov 26, 2024
* DOCSP-31824: Update page titles (#774) (cherry picked from commit 9cd60b1) * DOCSP-30081: Fix find to find() * docsp-32718 - add comments (#770) (cherry picked from commit 11461c3) * Added code comments (#772) (#778) (cherry picked from commit 5b0652a) * removed nested components * fixing bulkWrite * Fixing bulkwrite --------- Co-authored-by: Nora Reidy <[email protected]> Co-authored-by: Mike Woofter <[email protected]> Co-authored-by: Jordan Smith <[email protected]> (cherry picked from commit fa3f2bc)
caitlindavey
added a commit
that referenced
this pull request
Nov 26, 2024
* DOCSP-31824: Update page titles (#774) (cherry picked from commit 9cd60b1) * DOCSP-30081: Fix find to find() * docsp-32718 - add comments (#770) (cherry picked from commit 11461c3) * Added code comments (#772) (#778) (cherry picked from commit 5b0652a) * removed nested components * fixing bulkWrite * Fixing bulkwrite --------- Co-authored-by: Nora Reidy <[email protected]> Co-authored-by: Mike Woofter <[email protected]> Co-authored-by: Jordan Smith <[email protected]> (cherry picked from commit fa3f2bc)
caitlindavey
added a commit
that referenced
this pull request
Nov 26, 2024
* DOCSP-31824: Update page titles (#774) (cherry picked from commit 9cd60b1) * DOCSP-30081: Fix find to find() * docsp-32718 - add comments (#770) (cherry picked from commit 11461c3) * Added code comments (#772) (#778) (cherry picked from commit 5b0652a) * removed nested components * fixing bulkWrite * Fixing bulkwrite --------- Co-authored-by: Nora Reidy <[email protected]> Co-authored-by: Mike Woofter <[email protected]> Co-authored-by: Jordan Smith <[email protected]> (cherry picked from commit fa3f2bc)
caitlindavey
added a commit
that referenced
this pull request
Nov 26, 2024
* DOCSP-31824: Update page titles (#774) (cherry picked from commit 9cd60b1) * DOCSP-30081: Fix find to find() * docsp-32718 - add comments (#770) (cherry picked from commit 11461c3) * Added code comments (#772) (#778) (cherry picked from commit 5b0652a) * removed nested components * fixing bulkWrite * Fixing bulkwrite --------- Co-authored-by: Nora Reidy <[email protected]> Co-authored-by: Mike Woofter <[email protected]> Co-authored-by: Jordan Smith <[email protected]> (cherry picked from commit fa3f2bc)
caitlindavey
added a commit
that referenced
this pull request
Nov 26, 2024
* DOCSP-31824: Update page titles (#774) (cherry picked from commit 9cd60b1) * DOCSP-30081: Fix find to find() * docsp-32718 - add comments (#770) (cherry picked from commit 11461c3) * Added code comments (#772) (#778) (cherry picked from commit 5b0652a) * removed nested components * fixing bulkWrite * Fixing bulkwrite --------- Co-authored-by: Nora Reidy <[email protected]> Co-authored-by: Mike Woofter <[email protected]> Co-authored-by: Jordan Smith <[email protected]> (cherry picked from commit fa3f2bc)
caitlindavey
added a commit
that referenced
this pull request
Nov 26, 2024
* DOCSP-31824: Update page titles (#774) (cherry picked from commit 9cd60b1) * DOCSP-30081: Fix find to find() * docsp-32718 - add comments (#770) (cherry picked from commit 11461c3) * Added code comments (#772) (#778) (cherry picked from commit 5b0652a) * removed nested components * fixing bulkWrite * Fixing bulkwrite --------- Co-authored-by: Nora Reidy <[email protected]> Co-authored-by: Mike Woofter <[email protected]> Co-authored-by: Jordan Smith <[email protected]> (cherry picked from commit fa3f2bc)
caitlindavey
added a commit
that referenced
this pull request
Nov 26, 2024
* DOCSP-31824: Update page titles (#774) (cherry picked from commit 9cd60b1) * DOCSP-30081: Fix find to find() * docsp-32718 - add comments (#770) (cherry picked from commit 11461c3) * Added code comments (#772) (#778) (cherry picked from commit 5b0652a) * removed nested components * fixing bulkWrite * Fixing bulkwrite --------- Co-authored-by: Nora Reidy <[email protected]> Co-authored-by: Mike Woofter <[email protected]> Co-authored-by: Jordan Smith <[email protected]> (cherry picked from commit fa3f2bc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-32718
Staging:
Self-Review Checklist