-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EOL v3.6 #718
EOL v3.6 #718
Conversation
value = """\ | ||
This version of the documentation is archived and no longer supported. View the `current documentation <{+current-url-base+}>`__ to learn how to `upgrade your version of the {+driver-long+} <{+current-url-base+}/upgrade/>`__.\ | ||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: the upgrade guide doesn't tell users how to upgrade to new driver versions, it is a guide on breaking changes. Could you instead link to here/some other content to show users how to install newer versions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if they're upgrading from one of these older versions it's important for them to see the breaking changes first. Especially since we have the "Before you upgrade..." part in the top section.
That being said I do agree that it's a little confusing that a page called Upgrade Driver Versions doesn't actually tell how to perform the upgrade. Maybe we should add a section on that page stating (or linking to somewhere that states) how to actually install the new version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you create a ticket to add this section to the upgrade page?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
targets = ["*"] | ||
variant = "info" | ||
value = """\ | ||
This version of the documentation is archived and no longer supported. View the `current documentation <{+current-url-base+}>`__ to learn how to `upgrade your version of the {+driver-long+} <{+current-url-base+}/upgrade/>`__.\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This version of the documentation is archived and no longer supported. View the `current documentation <{+current-url-base+}>`__ to learn how to `upgrade your version of the {+driver-long+} <{+current-url-base+}/upgrade/>`__.\ | |
This version of the documentation is archived and no longer supported. View the `documentation for the current driver version <{+current-url-base+}>`__ to learn how to `upgrade your version of the {+driver-long+} <{+current-url-base+}/upgrade/>`__.\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The verbiage here is provided in the Wiki (under step 2) and I think is supposed to be standard for all pages that will have this banner, so I'm not sure if we should change it.
value = """\ | ||
This version of the documentation is archived and no longer supported. View the `current documentation <{+current-url-base+}>`__ to learn how to `upgrade your version of the {+driver-long+} <{+current-url-base+}/upgrade/>`__.\ | ||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you create a ticket to add this section to the upgrade page?
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-30855
Staging - https://docs-mongodbcom-staging.corp.mongodb.com/node/docsworker-xlarge/v3.6/
Self-Review Checklist