Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-2930: Move all CSS out of docs-tutorials into docs-tools #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

i80and
Copy link
Collaborator

@i80and i80and commented Aug 9, 2018

No description provided.

@i80and i80and requested a review from jdestefano-mongo August 9, 2018 18:37
Copy link
Collaborator

@jdestefano-mongo jdestefano-mongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Staging appears to have a different font. Checked using Chrome and Firefox. Otherwise, one question.

Regards,
Jon

@@ -10,9 +10,8 @@

<title>{title}</title>

<link rel="stylesheet" href="css/style.min.css" />
<link rel="stylesheet" href="css/landing.css" />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we not want to minify this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is minified; this is just matching the naming convention of mongodb-docs.css

@i80and
Copy link
Collaborator Author

i80and commented Aug 20, 2018

The font difference is present on all staged views due to a CORS violation. It'll look fine in prod

Copy link
Collaborator

@jdestefano-mongo jdestefano-mongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm mod the CORS font issue.

Regards,
Jon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants