Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-31907 - Add paragraph from server docs #460

Conversation

jordan-smith721
Copy link
Contributor

@jordan-smith721 jordan-smith721 commented Oct 3, 2023

Pull Request Info

Adding a paragraph to the Split Change Stream events section per tech review (commented on another PR)

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-31907
Staging - https://preview-mongodbjordansmith721.gatsbyjs.io/java/DOCSP-31907-split-event-add-note/fundamentals/crud/read-operations/change-streams/#split-large-change-stream-events

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?

Copy link
Collaborator

@caitlindavey caitlindavey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment otherwise LGTM.


Use ``$changeStreamSplitLargeEvent`` only when strictly necessary. For
example, use ``$changeStreamSplitLargeEvent`` if your application requires full
document pre- or post-images, and generates large events that exceed 16 MB.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I think "large" is redundant with "that exceed 16 MB."

Suggested change
document pre- or post-images, and generates large events that exceed 16 MB.
document pre- or post-images, and generates events that exceed 16 MB.

@jordan-smith721 jordan-smith721 mentioned this pull request Oct 3, 2023
4 tasks
@jordan-smith721 jordan-smith721 merged commit 6cf312f into mongodb:master Oct 3, 2023
2 checks passed
norareidy added a commit that referenced this pull request Oct 4, 2023
* DOCSP-32942: Deprecated Methods

* review feedback

* DOCSP-33241: fix extended JSON example id field (#447)

* DOCSP-33241: fix extended JSON example id field

* DOCSP-31694: SOCKS5 proxy support (#439)

* DOCSP-31694: SOCKS5 proxy support

* DOCSP-33300: Fix aggregation operator links to the manual (#448)

* DOCSP-32300 Adds compatibility info to landing page (#449)

* DOCSP-31907 Split Event (#457)

* tech review feedback

* format

* CC feedback

* CC feedback pt 2

* DOCSP-31907 - Add paragraph from server docs (#460)

* DOCSP-32942: Deprecated Methods

* review feedback

* tech review feedback

* format

* CC feedback

* CC feedback pt 2

* build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants