Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docsp 42960 nested components #387

Merged
merged 4 commits into from
Sep 27, 2024
Merged

Docsp 42960 nested components #387

merged 4 commits into from
Sep 27, 2024

Conversation

caitlindavey
Copy link
Collaborator

@caitlindavey caitlindavey commented Sep 25, 2024 •
edited
Loading

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-42960
Staging - Run a command https://deploy-preview-387--docs-golang.netlify.app/fundamentals/run-command/
Staging - Transactions https://deploy-preview-387--docs-golang.netlify.app/fundamentals/transactions/
Staging - Retrieve https://deploy-preview-387--docs-golang.netlify.app/fundamentals/crud/read-operations/retrieve/#modify-behavior

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

@netlify Netlify
Copy link

netlify bot commented Sep 25, 2024 •
edited
Loading

✅ Deploy Preview for docs-golang ready!

Name Link
🔨 Latest commit 2c559dd
🔍 Latest deploy log https://app.netlify.com/sites/docs-golang/deploys/66f5a77819766b0008f86394
😎 Deploy Preview https://deploy-preview-387--docs-golang.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

rustagir
rustagir requested changes Sep 26, 2024
View reviewed changes
source/fundamentals/transactions.txt Outdated
Comment on lines 99 to 105
| The ``CommitTransaction()`` method is an idempotent function, which
means that you can attempt to commit a transaction multiple times
without changing data after the first successful commit.
A transaction can succeed but return an error with the
``UnknownTransactionCommitResult`` label. If you rerun the
``CommitTransaction()`` method after receiving this error,
your data is not changed by the repeat attempts.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I: I think there is an error with the indentation or spacing here as it's not appearing in the staging

rustagir
rustagir approved these changes Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@rustagir rustagir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@caitlindavey caitlindavey merged commit cb6466d into mongodb:master Sep 27, 2024
4 of 5 checks passed
caitlindavey added a commit to caitlindavey/docs-golang that referenced this pull request Sep 27, 2024
@caitlindavey
Docsp 42960 nested components (mongodb#387)
a474460 
* DOCSP-42960: Removing nested components in go pages

* DOCSP-42960: Removing nested components in go pages

* DOCSP-42960: Removing nested components spacing updates

* DOCSP-42960: Removing nested components fixing rst error

(cherry picked from commit cb6466d)
caitlindavey added a commit to caitlindavey/docs-golang that referenced this pull request Sep 27, 2024
@caitlindavey
Docsp 42960 nested components (mongodb#387)
62b6595 
* DOCSP-42960: Removing nested components in go pages

* DOCSP-42960: Removing nested components in go pages

* DOCSP-42960: Removing nested components spacing updates

* DOCSP-42960: Removing nested components fixing rst error

(cherry picked from commit cb6466d)
caitlindavey added a commit to caitlindavey/docs-golang that referenced this pull request Sep 27, 2024
@caitlindavey
Docsp 42960 nested components (mongodb#387)
a78101c 
* DOCSP-42960: Removing nested components in go pages

* DOCSP-42960: Removing nested components in go pages

* DOCSP-42960: Removing nested components spacing updates

* DOCSP-42960: Removing nested components fixing rst error

(cherry picked from commit cb6466d)
caitlindavey added a commit to caitlindavey/docs-golang that referenced this pull request Sep 27, 2024
@caitlindavey
Docsp 42960 nested components (mongodb#387)
ed88fdb 
* DOCSP-42960: Removing nested components in go pages

* DOCSP-42960: Removing nested components in go pages

* DOCSP-42960: Removing nested components spacing updates

* DOCSP-42960: Removing nested components fixing rst error

(cherry picked from commit cb6466d)
caitlindavey added a commit to caitlindavey/docs-golang that referenced this pull request Sep 27, 2024
@caitlindavey
Docsp 42960 nested components (mongodb#387)
ffa2f8f 
* DOCSP-42960: Removing nested components in go pages

* DOCSP-42960: Removing nested components in go pages

* DOCSP-42960: Removing nested components spacing updates

* DOCSP-42960: Removing nested components fixing rst error

(cherry picked from commit cb6466d)
caitlindavey added a commit to caitlindavey/docs-golang that referenced this pull request Sep 27, 2024
@caitlindavey
Docsp 42960 nested components (mongodb#387)
b64961a 
* DOCSP-42960: Removing nested components in go pages

* DOCSP-42960: Removing nested components in go pages

* DOCSP-42960: Removing nested components spacing updates

* DOCSP-42960: Removing nested components fixing rst error

(cherry picked from commit cb6466d)
caitlindavey added a commit to caitlindavey/docs-golang that referenced this pull request Sep 27, 2024
@caitlindavey
Docsp 42960 nested components (mongodb#387)
2603912 
* DOCSP-42960: Removing nested components in go pages

* DOCSP-42960: Removing nested components in go pages

* DOCSP-42960: Removing nested components spacing updates

* DOCSP-42960: Removing nested components fixing rst error

(cherry picked from commit cb6466d)
caitlindavey added a commit that referenced this pull request Oct 4, 2024
@caitlindavey
Docsp 42960 nested components (#387) (#388)
5490dfe 
* DOCSP-42960: Removing nested components in go pages

* DOCSP-42960: Removing nested components in go pages

* DOCSP-42960: Removing nested components spacing updates

* DOCSP-42960: Removing nested components fixing rst error

(cherry picked from commit cb6466d)
caitlindavey added a commit that referenced this pull request Oct 4, 2024
@caitlindavey
Docsp 42960 nested components (#387) (#389)
34f354a 
* DOCSP-42960: Removing nested components in go pages

* DOCSP-42960: Removing nested components in go pages

* DOCSP-42960: Removing nested components spacing updates

* DOCSP-42960: Removing nested components fixing rst error

(cherry picked from commit cb6466d)
caitlindavey added a commit that referenced this pull request Oct 4, 2024
@caitlindavey
Docsp 42960 nested components (#387) (#390)
7437c03 
* DOCSP-42960: Removing nested components in go pages

* DOCSP-42960: Removing nested components in go pages

* DOCSP-42960: Removing nested components spacing updates

* DOCSP-42960: Removing nested components fixing rst error

(cherry picked from commit cb6466d)
caitlindavey added a commit that referenced this pull request Oct 4, 2024
@caitlindavey
Docsp 42960 nested components (#387) (#394)
5881d29 
* DOCSP-42960: Removing nested components in go pages

* DOCSP-42960: Removing nested components in go pages

* DOCSP-42960: Removing nested components spacing updates

* DOCSP-42960: Removing nested components fixing rst error

(cherry picked from commit cb6466d)
caitlindavey added a commit that referenced this pull request Oct 4, 2024
@caitlindavey
Docsp 42960 nested components (#387) (#393)
de2a32e 
* DOCSP-42960: Removing nested components in go pages

* DOCSP-42960: Removing nested components in go pages

* DOCSP-42960: Removing nested components spacing updates

* DOCSP-42960: Removing nested components fixing rst error

(cherry picked from commit cb6466d)
caitlindavey added a commit that referenced this pull request Oct 4, 2024
@caitlindavey
Docsp 42960 nested components (#387) (#391)
618aa39 
* DOCSP-42960: Removing nested components in go pages

* DOCSP-42960: Removing nested components in go pages

* DOCSP-42960: Removing nested components spacing updates

* DOCSP-42960: Removing nested components fixing rst error

(cherry picked from commit cb6466d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rustagir rustagir rustagir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caitlindavey @rustagir