Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-43402: link to migration guide + clarify lang #381

Merged
merged 3 commits into from
Sep 16, 2024

Conversation

rustagir
Copy link
Collaborator

@rustagir rustagir commented Sep 10, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-43403
Staging - https://deploy-preview-381--docs-golang.netlify.app/whats-new/#what-s-new-in-2.0

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link

netlify bot commented Sep 10, 2024

Deploy Preview for docs-golang ready!

Name Link
🔨 Latest commit a041871
🔍 Latest deploy log https://app.netlify.com/sites/docs-golang/deploys/66e871a82b4c840008cc882d
😎 Deploy Preview https://deploy-preview-381--docs-golang.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@mongoKart mongoKart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm w/ comments

The 2.0 {+driver-short+} release supports various new features, provides
a smoother timeout experience, and implements clearer, more idiomatic Go
The 2.0 {+driver-short+} release supports OpenID Connect (OIDC)
authentication, provides a smoother Client-Side Operations Timeout
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: we don't capitalize this elsewhere, though I'm not sure which is correct. See, e.g., https://www.mongodb.com/docs/languages/python/pymongo-driver/current/connect/csot/

Suggested change
authentication, provides a smoother Client-Side Operations Timeout
authentication, provides a smoother client-side operations timeout

@@ -99,6 +103,10 @@ In this section, you can learn more about these changes.

This release includes the following improvements and fixes:

- Support for OpenID Connect (OIDC) authentication. To learn more, see
:atlas:`Authentication and Authorization with OIDC/OAuth 2.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: will this be a link to the Go OIDC section when that's done?

@rustagir rustagir merged commit b671266 into mongodb:master Sep 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants