Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-34822: commitTxn is idempotent #337

Merged
merged 5 commits into from
Jan 18, 2024

Conversation

rustagir
Copy link
Collaborator

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-34822
Staging

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link
Collaborator

@jordan-smith721 jordan-smith721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w/ a small suggestion

Comment on lines 75 to 76
information, see :manual:`startTransaction()
</reference/method/Session.startTransaction/>` in the Server manual.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: I think these sentences would flow a little better when we say "see the guide (or page) in the..."
Applies to all "For more information..." instances

Suggested change
information, see :manual:`startTransaction()
</reference/method/Session.startTransaction/>` in the Server manual.
information, see the :manual:`startTransaction()
</reference/method/Session.startTransaction/>` guide in the Server manual.


.. note:: Retrying a Transaction

The ``CommitTransaction()`` method is an idempotent function, which
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CommitTransaction appears idempotent in experimentation, but I can't find server documentation supporting this. Can we assign someone on the server team to review this PR to ensure this is a true statement?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure - I misunderstood the ticket. I can ask a server engineer to review and confirm.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per https://mongodb.slack.com/archives/C0V2Z88D8/p1705590222161309, this function is idempotent, but revising the wording to reflect the Server engineer's suggestion!

@rustagir rustagir merged commit 40d675e into mongodb:master Jan 18, 2024
2 checks passed
rustagir added a commit that referenced this pull request Jan 18, 2024
* DOCSP-34822: commitTxn is idempotent

* vale fixes

* Server clarification

* JS PR fix

* language

(cherry picked from commit 40d675e)
rustagir added a commit that referenced this pull request Jan 18, 2024
* DOCSP-34822: commitTxn is idempotent

* vale fixes

* Server clarification

* JS PR fix

* language

(cherry picked from commit 40d675e)
rustagir added a commit that referenced this pull request Jan 18, 2024
* DOCSP-34822: commitTxn is idempotent

* vale fixes

* Server clarification

* JS PR fix

* language

(cherry picked from commit 40d675e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants