-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-34822: commitTxn is idempotent #337
DOCSP-34822: commitTxn is idempotent #337
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM w/ a small suggestion
source/fundamentals/transactions.txt
Outdated
information, see :manual:`startTransaction() | ||
</reference/method/Session.startTransaction/>` in the Server manual. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: I think these sentences would flow a little better when we say "see the guide (or page) in the..."
Applies to all "For more information..." instances
information, see :manual:`startTransaction() | |
</reference/method/Session.startTransaction/>` in the Server manual. | |
information, see the :manual:`startTransaction() | |
</reference/method/Session.startTransaction/>` guide in the Server manual. |
|
||
.. note:: Retrying a Transaction | ||
|
||
The ``CommitTransaction()`` method is an idempotent function, which |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CommitTransaction appears idempotent in experimentation, but I can't find server documentation supporting this. Can we assign someone on the server team to review this PR to ensure this is a true statement?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure - I misunderstood the ticket. I can ask a server engineer to review and confirm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per https://mongodb.slack.com/archives/C0V2Z88D8/p1705590222161309, this function is idempotent, but revising the wording to reflect the Server engineer's suggestion!
* DOCSP-34822: commitTxn is idempotent * vale fixes * Server clarification * JS PR fix * language (cherry picked from commit 40d675e)
* DOCSP-34822: commitTxn is idempotent * vale fixes * Server clarification * JS PR fix * language (cherry picked from commit 40d675e)
* DOCSP-34822: commitTxn is idempotent * vale fixes * Server clarification * JS PR fix * language (cherry picked from commit 40d675e)
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-34822
Staging
Self-Review Checklist