Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-35360: fix single index code snippet #332

Merged

Conversation

ccho-mongodb
Copy link
Contributor

@ccho-mongodb ccho-mongodb commented Jan 9, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-35360
Staging - https://preview-mongodbcchomongodb.gatsbyjs.io/golang/DOCSP-35360-fix-single-index-code/fundamentals/indexes/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

indexModel := mongo.IndexModel{
Keys: bson.D{{"title", 1}}
Keys: bson.D{{"title", 1}},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line contains the syntax fix.

Copy link
Collaborator

@rustagir rustagir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but noticed some things

often in your queries and operations that return sorted results. You
should track index memory and disk usage for capacity planning since
often in your queries and operations that return sorted results. Track
index memory and disk usage for capacity planning since
each index that you add consumes disk space and memory. In addition,
when a write operation updates an indexed field, MongoDB
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: noticed a double space here, fix

@@ -283,7 +290,7 @@ within the compound index.

Text indexes differ from the more powerful
:atlas:`Atlas full text search indexes </atlas-search>`.
Atlas users should use Atlas search.
We recommend that Atlas search for Atlas users.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
We recommend that Atlas search for Atlas users.
We recommend Atlas search for Atlas users.

@ccho-mongodb ccho-mongodb merged commit 7aa4036 into mongodb:master Jan 9, 2024
2 checks passed
@ccho-mongodb ccho-mongodb deleted the DOCSP-35360-fix-single-index-code branch January 9, 2024 15:04
ccho-mongodb pushed a commit that referenced this pull request Jan 9, 2024
…x-code

DOCSP-35360: fix single index code snippet
(cherry picked from commit 7aa4036)
ccho-mongodb pushed a commit that referenced this pull request Jan 9, 2024
…x-code

DOCSP-35360: fix single index code snippet
(cherry picked from commit 7aa4036)
ccho-mongodb pushed a commit that referenced this pull request Jan 9, 2024
…x-code

DOCSP-35360: fix single index code snippet
(cherry picked from commit 7aa4036)
ccho-mongodb pushed a commit that referenced this pull request Jan 9, 2024
…x-code

DOCSP-35360: fix single index code snippet
(cherry picked from commit 7aa4036)
(cherry picked from commit 7b16d0c)
ccho-mongodb pushed a commit that referenced this pull request Jan 9, 2024
…x-code

DOCSP-35360: fix single index code snippet
(cherry picked from commit 7aa4036)
ccho-mongodb pushed a commit that referenced this pull request Jan 9, 2024
…x-code

DOCSP-35360: fix single index code snippet
(cherry picked from commit 7aa4036)
(cherry picked from commit 7b16d0c)
ccho-mongodb pushed a commit that referenced this pull request Jan 9, 2024
…x-code

DOCSP-35360: fix single index code snippet
(cherry picked from commit 7aa4036)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants