Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-34174: codewhisperer pt 5 #324

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

rustagir
Copy link
Collaborator

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-34174
Staging -
textsearch
skip
sort
command
arrays

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link
Collaborator

@norareidy norareidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -31,16 +32,22 @@ func main() {

// start-runcommand
db := client.Database("plants")

// Creates commands to count documents in a collection and explain
// the how the count command runs
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// the how the count command runs
// how the count command runs

@@ -56,6 +58,8 @@ func main() {

fmt.Println("\nAscending Sort:\n")
{
// Retrieves matching documents and sets an ascending sort on
// "enrollment"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S:

Suggested change
// "enrollment"
// the "enrollment" field

@@ -75,6 +81,8 @@ func main() {

fmt.Println("\nDescending Sort:\n")
{
// Retrieves matching documents and sets a descending sort on
// "enrollment"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S:

Suggested change
// "enrollment"
// the "enrollment" field

@@ -94,6 +104,8 @@ func main() {

fmt.Println("\nMulti Sort:\n")
{
// Retrieves matching documents and sets a descending sort on
// "enrollment" and an ascending sort on "title"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// "enrollment" and an ascending sort on "title"
// the "enrollment" field and an ascending sort on the "title" field

@@ -113,6 +127,8 @@ func main() {

fmt.Println("\nAggregation Sort:\n")
{
// Uses an aggregation pipeline to set a descending sort on
// "enrollment" and an ascending sort on "title"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: same as above (line 108)

@@ -86,13 +91,17 @@ func main() {

fmt.Println("\nPositional $[<identifier>] Operator:\n")
{
// Creates a filter and update document to match "sizes" array
// entries and remove those values
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: just to make it a little clearer

Suggested change
// entries and remove those values
// values and remove those values

@rustagir rustagir merged commit 883f730 into mongodb:master Nov 29, 2023
2 checks passed
rustagir added a commit that referenced this pull request Nov 30, 2023
* DOCSP-34174: codewhisperer pt 5

* NR PR fixes
rustagir added a commit that referenced this pull request Nov 30, 2023
* DOCSP-34174: codewhisperer pt 5

* NR PR fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants