Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-34174: codewhisperer pt 4 #323

Merged
merged 3 commits into from
Nov 29, 2023

Conversation

rustagir
Copy link
Collaborator

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-34174

Staging
timeseries
transaction
TLS
connection guide

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link
Collaborator

@rachel-mack rachel-mack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple minor things:

@@ -33,21 +34,26 @@ func main() {

// begin create ts coll
db := client.Database("spring_weather")

// Creates a time series collection that stores "temperature" values over time
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we should be using timeseries or time series, but it should be consistent

Suggested change
// Creates a time series collection that stores "temperature" values over time
// Creates a timeseries collection that stores "temperature" values over time

Comment on lines 44 to 45
// Inserts multiple documents into a collection within a transaction
// and commits or ends the transaction
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smallest imaginable nit:

Suggested change
// Inserts multiple documents into a collection within a transaction
// and commits or ends the transaction
// Inserts multiple documents into a collection within a transaction,
// and commits or ends the transaction

@rustagir rustagir merged commit c1e75aa into mongodb:master Nov 29, 2023
2 checks passed
rustagir added a commit that referenced this pull request Nov 30, 2023
* DOCSP-34174: codewhisperer pt 4

* highlighting fix

* RM PR fixes
rustagir added a commit that referenced this pull request Nov 30, 2023
* DOCSP-34174: codewhisperer pt 4

* highlighting fix

* RM PR fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants