-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-34174: codewhisperer pt 1 #320
DOCSP-34174: codewhisperer pt 1 #320
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM + a couple things!
//begin multi options | ||
filter := bson.D{} | ||
|
||
// Sets options to sort by descending order on "enrollment", | ||
// return only 2 documents, and skip the 1 matched document |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S:
// return only 2 documents, and skip the 1 matched document | |
// return only 2 documents, and skip the first matched document |
// begin aggregate projection | ||
projectStage := bson.D{{"$project", bson.D{{"title", 1}, {"course_id", 1}}}} | ||
|
||
// Aggregates results and prints them as structs with the | ||
// specified projection |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: for consistency, maybe change this to "...prints them as structs including only the specified fields"
* DOCSP-34174: codewhisperer pt 1 * add comments * NR PR fixes 1 * fix index (cherry picked from commit 77557c6)
* DOCSP-34174: codewhisperer pt 1 * add comments * NR PR fixes 1 * fix index (cherry picked from commit 77557c6)
* DOCSP-34174: codewhisperer pt 1 * add comments * NR PR fixes 1 * fix index (cherry picked from commit 77557c6)
* DOCSP-34174: codewhisperer pt 1 * add comments * NR PR fixes 1 * fix index (cherry picked from commit 77557c6)
* DOCSP-34174: codewhisperer pt 1 * add comments * NR PR fixes 1 * fix index (cherry picked from commit 77557c6)
* DOCSP-34174: codewhisperer pt 1 * add comments * NR PR fixes 1 * fix index (cherry picked from commit 77557c6)
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-34174
Staging:
specify query
retrieve
limit
project
Self-Review Checklist