Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-34174: codewhisperer pt 1 #320

Merged
merged 4 commits into from
Nov 28, 2023

Conversation

rustagir
Copy link
Collaborator

@rustagir rustagir commented Nov 27, 2023

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-34174
Staging:
specify query
retrieve
limit
project

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link
Collaborator

@norareidy norareidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM + a couple things!

//begin multi options
filter := bson.D{}

// Sets options to sort by descending order on "enrollment",
// return only 2 documents, and skip the 1 matched document
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S:

Suggested change
// return only 2 documents, and skip the 1 matched document
// return only 2 documents, and skip the first matched document

// begin aggregate projection
projectStage := bson.D{{"$project", bson.D{{"title", 1}, {"course_id", 1}}}}

// Aggregates results and prints them as structs with the
// specified projection
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: for consistency, maybe change this to "...prints them as structs including only the specified fields"

@rustagir rustagir merged commit 77557c6 into mongodb:master Nov 28, 2023
2 checks passed
rustagir added a commit that referenced this pull request Nov 28, 2023
* DOCSP-34174: codewhisperer pt 1

* add comments

* NR PR fixes 1

* fix index

(cherry picked from commit 77557c6)
rustagir added a commit that referenced this pull request Nov 28, 2023
* DOCSP-34174: codewhisperer pt 1

* add comments

* NR PR fixes 1

* fix index

(cherry picked from commit 77557c6)
rustagir added a commit that referenced this pull request Nov 28, 2023
* DOCSP-34174: codewhisperer pt 1

* add comments

* NR PR fixes 1

* fix index

(cherry picked from commit 77557c6)
rustagir added a commit that referenced this pull request Nov 28, 2023
* DOCSP-34174: codewhisperer pt 1

* add comments

* NR PR fixes 1

* fix index

(cherry picked from commit 77557c6)
rustagir added a commit that referenced this pull request Nov 28, 2023
* DOCSP-34174: codewhisperer pt 1

* add comments

* NR PR fixes 1

* fix index

(cherry picked from commit 77557c6)
rustagir added a commit that referenced this pull request Nov 28, 2023
* DOCSP-34174: codewhisperer pt 1

* add comments

* NR PR fixes 1

* fix index

(cherry picked from commit 77557c6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants