DOCSP-32693: FindOne by ObjectId #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustagir
requested changes
Oct 2, 2023
rustagir
requested changes
Oct 2, 2023
rustagir
approved these changes
Oct 3, 2023
| :language: none | ||
| :visible: false | ||
|
|
||
| {"item":"Hibiscus","rating":4} |
There was a problem hiding this comment.
Q: this output shows the field names as lowercase, but if the code is unmarshalling the document to the Review type, it should look different, as it should print with the fieldnames from the struct.
There was a problem hiding this comment.
When I run the code, it outputs the lowercase field names so maybe it's not unmarshalling to a Review? I might be missing something in the code
There was a problem hiding this comment.
I think the field names will stay lowercase after using the MarshalExtJSON() function, unless I unmarshal again into the struct. Looks like the printed documents on this page also have lowercase fields.
norareidy
added a commit
that referenced
this pull request
Oct 5, 2023
* DOCSP-32693: FindOne by ObjectId * fixing code * adding callout + text * code spacing * reword * error message * most feedback + stage * adding label * fix highlight * move code to separate file * fix literalinclude * includes * io code blocks * feedback pt 2 * code typos * last suggestions * fix (cherry picked from commit b488097)
norareidy
added a commit
that referenced
this pull request
Oct 5, 2023
* DOCSP-32693: FindOne by ObjectId * fixing code * adding callout + text * code spacing * reword * error message * most feedback + stage * adding label * fix highlight * move code to separate file * fix literalinclude * includes * io code blocks * feedback pt 2 * code typos * last suggestions * fix (cherry picked from commit b488097) (cherry picked from commit 36da935)
norareidy
added a commit
that referenced
this pull request
Oct 5, 2023
* DOCSP-32693: FindOne by ObjectId * fixing code * adding callout + text * code spacing * reword * error message * most feedback + stage * adding label * fix highlight * move code to separate file * fix literalinclude * includes * io code blocks * feedback pt 2 * code typos * last suggestions * fix (cherry picked from commit b488097) (cherry picked from commit 36da935)
norareidy
added a commit
that referenced
this pull request
Oct 5, 2023
* DOCSP-32693: FindOne by ObjectId * fixing code * adding callout + text * code spacing * reword * error message * most feedback + stage * adding label * fix highlight * move code to separate file * fix literalinclude * includes * io code blocks * feedback pt 2 * code typos * last suggestions * fix (cherry picked from commit b488097) (cherry picked from commit 36da935)
norareidy
added a commit
that referenced
this pull request
Oct 5, 2023
* DOCSP-32693: FindOne by ObjectId * fixing code * adding callout + text * code spacing * reword * error message * most feedback + stage * adding label * fix highlight * move code to separate file * fix literalinclude * includes * io code blocks * feedback pt 2 * code typos * last suggestions * fix (cherry picked from commit b488097) (cherry picked from commit 36da935)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-32693
Staging - https://docs-mongodbcom-staging.corp.mongodb.com/golang/docsworker-xlarge/DOCSP-32693-find-by-id/fundamentals/crud/read-operations/retrieve/
Self-Review Checklist