Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-45728-compressors-option #179

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

jeff-allen-mongo
Copy link
Collaborator

@jeff-allen-mongo jeff-allen-mongo commented Dec 4, 2024

DESCRIPTION

Document the compressors option for mongodump and mongorestore

STAGING

JIRA

https://jira.mongodb.org/browse/DOCSP-45728

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Is this free of spelling errors?
  • Is this free of grammatical errors?
  • Is this free of staging / rendering issues?
  • Are all the links working?

External Review Requirements

What's expected of an external reviewer?

Copy link

netlify bot commented Dec 4, 2024

Deploy Preview for docs-commandline-tools ready!

Name Link
🔨 Latest commit 85c2fa6
🔍 Latest deploy log https://app.netlify.com/sites/docs-commandline-tools/deploys/6750ab3ae82d100009bb5721
😎 Deploy Preview https://deploy-preview-179--docs-commandline-tools.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@sarah-olson-mongodb sarah-olson-mongodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jeff-allen-mongo! LGTM with a couple suggestions for your consideration.

@@ -0,0 +1,14 @@
Specify the compression algorithm used between the MongoDB server and
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(parallelism)
Consider "Specifies" rather than "Specify" to create parallelism between this and the other options.

@@ -0,0 +1,14 @@
Specify the compression algorithm used between the MongoDB server and
|tool-binary|. You can specify one or more of these values for the
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(word choice)
Maybe "use" or "include" to avoid repeating specify.

@jeff-allen-mongo jeff-allen-mongo merged commit 6f05dfe into mongodb:master Dec 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants