DOCSP-24948-mongorestore-nsExclude-nsInclude-precedence #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-commandline-tools ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jmd-mongo
force-pushed
the
DOCSP-24948
branch
from
59d2434 to
e3b3502
Compare
sarah-olson-mongodb
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Thanks for these updates @jmd-mongo. LGTM with one optional suggestion.
Comment on lines
3
to
5
| specify both ``--nsExclude="prod.*"`` and ``--nsInclude="prod.trips"``, | ||
| the pattern specified by ``--nsExclude`` takes precedence and no | ||
| collections from the ``prod`` namespace are restored. |
There was a problem hiding this comment.
(optional minimalism suggestion)
To avoid repeating "the pattern specified by ..."
Suggested change
| specify both ``--nsExclude="prod.*"`` and ``--nsInclude="prod.trips"``, | |
| the pattern specified by ``--nsExclude`` takes precedence and no | |
| collections from the ``prod`` namespace are restored. | |
| specify both ``--nsExclude="prod.*"`` and ``--nsInclude="prod.trips"``, no | |
| collections from the ``prod`` namespace are restored. |
rohshar
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION
Documents that
--nsExcludetakes precedence over--nsIncludein cases where both are specified.Test Results: https://gist.github.com/jmd-mongo/63690ba41fcea86fcb8880902559b992
STAGING
JIRA
https://jira.mongodb.org/browse/DOCSP-24948
Self-Review Checklist
External Review Requirements
What's expected of an external reviewer?