Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(DOCSP-40177): Replace mongodump sharded cluster behavior with link t… #157

Merged
merged 4 commits into from
Jun 11, 2024

Conversation

jeff-allen-mongo
Copy link
Collaborator

@jeff-allen-mongo jeff-allen-mongo commented Jun 4, 2024

…o tutorial

DESCRIPTION

Replace standalone mongodump behavior details with link to the recently-updated tutorial.

STAGING

https://preview-mongodbjeffallenmongo.gatsbyjs.io/database-tools/DOCSP-40177/mongodump/mongodump-behavior/#sharded-clusters

JIRA

https://jira.mongodb.org/browse/DOCSP-40177

BUILD LOG

https://workerpool-boxgs.mongodbstitch.com/pages/job.html?collName=queue&jobId=665f809fcf5bec1c2965e4af

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Is this free of spelling errors?
  • Is this free of grammatical errors?
  • Is this free of staging / rendering issues?
  • Are all the links working?

External Review Requirements

What's expected of an external reviewer?

Copy link
Contributor

@jmd-mongo jmd-mongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix, @jeff-allen-mongo! This one LGTM.

Thanks,
Joe

Copy link

@mvankeulen94 mvankeulen94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this! Added a comment for consideration.

*do maintain* the atomicity guarantees of transactions across shards:
Sharded clusters can also use one of the following coordinated backup
and restore processes, which maintain the atomicity guarantees of
transactions across shards:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to also mention that these solutions provide these atomicity guarantees while still accepting writes?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!

@jeff-allen-mongo
Copy link
Collaborator Author

@mvankeulen94 thanks for the feedback! I tweaked the copy per your suggestion. Could you take another look?

Copy link

@mvankeulen94 mvankeulen94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds great, thank you!

@jeff-allen-mongo jeff-allen-mongo merged commit 21e83ac into mongodb:master Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants