-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-39421-detailed-extras #151
DOCSP-39421-detailed-extras #151
Conversation
4316929
to
570b224
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Jason, LGTM with one suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated per review feedback. Sending on for ext review.
adding a placeholder comment here so I can be added as a reviewer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is excellent, thank you. LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you! I have one wording comment, otherwise LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updates per feedback.
DESCRIPTION
Added extra details for mongodump per request.
Unfortunately, we cannot doc both mongodump and mongorestore on the same page because of how the docs platform works. Each set of options tags on a doc page must be tied to the tool tag itself ("mongodump" or "mongorestore"). We also have a docs standards requirement to try to keep pages shorter. Added other details per JIRA.
STAGING
https://preview-mongodbjasonpricemongodb.gatsbyjs.io/database-tools/DOCSP-39421-detailed-extras/mongodump/#definition
JIRA
https://jira.mongodb.org/browse/DOCSP-39421
BUILD LOG
https://workerpool-boxgs.mongodbstitch.com/pages/job.html?collName=queue&jobId=664e64b6cf5bec1c29d25d35
Self-Review Checklist
External Review Requirements
What's expected of an external reviewer?