Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-39421-detailed-extras #151

Conversation

jason-price-mongodb
Copy link
Contributor

@jason-price-mongodb jason-price-mongodb commented May 21, 2024

DESCRIPTION

Added extra details for mongodump per request.

Unfortunately, we cannot doc both mongodump and mongorestore on the same page because of how the docs platform works. Each set of options tags on a doc page must be tied to the tool tag itself ("mongodump" or "mongorestore"). We also have a docs standards requirement to try to keep pages shorter. Added other details per JIRA.

STAGING

https://preview-mongodbjasonpricemongodb.gatsbyjs.io/database-tools/DOCSP-39421-detailed-extras/mongodump/#definition

JIRA

https://jira.mongodb.org/browse/DOCSP-39421

BUILD LOG

https://workerpool-boxgs.mongodbstitch.com/pages/job.html?collName=queue&jobId=664e64b6cf5bec1c29d25d35

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Is this free of spelling errors?
  • Is this free of grammatical errors?
  • Is this free of staging / rendering issues?
  • Are all the links working?

External Review Requirements

What's expected of an external reviewer?

@jason-price-mongodb jason-price-mongodb force-pushed the DOCSP-39421-detailed-extras branch from 4316929 to 570b224 Compare May 22, 2024 21:22
Copy link
Collaborator

@nvillahermosa-mdb nvillahermosa-mdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jason, LGTM with one suggestion.

source/mongodump.txt Outdated Show resolved Hide resolved
Copy link
Contributor Author

@jason-price-mongodb jason-price-mongodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated per review feedback. Sending on for ext review.

source/mongodump.txt Outdated Show resolved Hide resolved
@mvankeulen94
Copy link

adding a placeholder comment here so I can be added as a reviewer

Copy link
Member

@tfogo tfogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is excellent, thank you. LGTM!

Copy link

@mvankeulen94 mvankeulen94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you! I have one wording comment, otherwise LGTM!

source/mongodump.txt Outdated Show resolved Hide resolved
Copy link
Contributor Author

@jason-price-mongodb jason-price-mongodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates per feedback.

source/mongodump.txt Outdated Show resolved Hide resolved
@jason-price-mongodb jason-price-mongodb merged commit 4fdf97d into mongodb:master May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants