DOCSP-33862-mongorestore-example #146
Conversation
There was a problem hiding this comment.
Thanks for this update, @jason-price-mongodb! I've left a non-blocking for your consideration, but otherwise this LGTM.
Thanks!
Joe
|
Hi there, |
|
@ohassanmongodb please re-review. Thanks! |
|
@mvankeulen94 please review. Thanks! |
| To back up a database at a specific point in time to an :term:`oplog` | ||
| file, use :option:`mongodump --oplog`. To restore the database at a | ||
| point in time with an oplog file, use :option:`mongorestore | ||
| --oplogReplay`. For more details, see :ref:`backup-restore-oplogreplay`. |
There was a problem hiding this comment.
We should add a note that there are restrictions on when --oplog can be called.
https://jira.mongodb.org/browse/DOCSP-38779 is in progress, which adds additional corrections on when --oplog can safely be called. Ideally we can complete that ticket prior to pushing this.
|
The root issue with the confusion is we are labeling mongorestore as "point in time", and so users assume that they can choose the specific point in time to which they restore. They cannot do that safely with the DB Tools, so we'd prefer to not advertise this as a recommended use case. I discussed with the team, and we are in favor of instead updating all these references to "point in time" to state that, unless a user pauses writes for the duration of their mongodump, the only way to get a consistent backup is to use --oplog mode. |
|
@mvankeulen94 please re-review. I'll make the various changes to the server docs repo in a different PR. Thanks. |
|
@mvankeulen94 please re-review. Thanks. |
There was a problem hiding this comment.
Hey, I think we're overindexing on the specific misunderstanding the user in DOCSP-33862 had. It feels like we're trying to treat the symptom (the misunderstanding in DOCSP-33862) instead of treating the cause (we don't explain what mongodump does clearly enough).
I think that understanding how mongodump will dump inconsistent data without using --oplog is integral to understanding the tools. We should probably explain how this works more fully and it should probably be up front in the behavior section and even the main page.
Could we do more of a larger rewrite here? I think as it stands this PR is adding complexity and not tackling the root of the problem.
|
@mvankeulen94 @tfogo please re-review. Thanks. |
There was a problem hiding this comment.
LGTM as long as @mvankeulen94 is happy.
I can file the tickets to make the larger changes to the dump/restore docs.
There was a problem hiding this comment.
lgtm, thank you! Per Slack conversation, if we could wait on publishing these until https://jira.mongodb.org/browse/DOCSP-37996 is complete, that would be great.
DESCRIPTION
Added point in time info per Jira.
STAGING
https://preview-mongodbjasonpricemongodb.gatsbyjs.io/database-tools/DOCSP-33862-mongorestore-example/mongorestore/mongorestore-examples/#back-up-and-restore-a-database-to-a-specific-point-in-time
https://preview-mongodbjasonpricemongodb.gatsbyjs.io/database-tools/DOCSP-33862-mongorestore-example/mongorestore/#options
https://preview-mongodbjasonpricemongodb.gatsbyjs.io/database-tools/DOCSP-33862-mongorestore-example/mongodump/#options
JIRA
https://jira.mongodb.org/browse/DOCSP-33862
BUILD LOG
https://workerpool-boxgs.mongodbstitch.com/pages/job.html?collName=queue&jobId=661eb3b53a5920a291b8b3a7
Self-Review Checklist
External Review Requirements
What's expected of an external reviewer?