This repository has been archived by the owner on Oct 26, 2023. It is now read-only.
DEVHUB-220: Relative Link Fix #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jestapinski
commented
Sep 15, 2020
| @@ -6,7 +6,7 @@ exports[`renders correctly 1`] = ` | |||
| id="create-an-administrative-username-and-password" | |||
| > | |||
| <a | |||
| class="e1hiqreu0 css-tk4bib-StyledLink-PermaLink eygprlc0" | |||
| class="e1hiqreu0 css-b5zgq1-StyledLink-PermaLink eygprlc0" | |||
There was a problem hiding this comment.
Not sure why these were updated but seems harmless
jestapinski
commented
Sep 15, 2020
jestapinski
requested review from
jbouzi12,
melissarudofsky and
tahiya-mongo
melissarudofsky
approved these changes
Sep 15, 2020
|
Thanks! |
jestapinski
added a commit
that referenced
this pull request
Sep 15, 2020
staging --> master DEVHUB-220: Relative Link Fix (#508)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issue
Broken Series in Prod
Staging Link to Series Article
Staging Link to Article with Related Articles (just to confirm it still works)
Recently we updated Gatsby to v2.22.11 to v2.24. In 2.22.17 they changed the Link behavior so any paths without a leading slash are now interpreted as relative 🤦
This PR adds a check to the
Linkto add a leading slash should it not exist.To Verify: