-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Actions and Add Python-Specific Actions #6
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some feedback. Note that I haven't reviewed the Python action and would defer to someone from the Python team for that.
Co-authored-by: Andreas Braun <[email protected]>
Co-authored-by: Andreas Braun <[email protected]>
Co-authored-by: Andreas Braun <[email protected]>
version: | ||
description: "The published version" | ||
required: true | ||
post_version: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
post_version
is a little ambiguous: I'd prefer to rename this something more explicit like following_version
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
python/publish/publish.sh
Outdated
gh release upload ${VERSION} $RELEASE_ASSETS/*.* | ||
gh release view ${VERSION} >> $GITHUB_STEP_SUMMARY | ||
else | ||
echo "Dry run, not uploading to s3 or creating GitHub Release" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to have the dry run print information about what it would have published?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Co-authored-by: Noah Stapp <[email protected]>
Co-authored-by: Noah Stapp <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small suggestion to use the v2
tag in the readme, but since we haven't tagged it yet I'll let you decide whether you want to make the change now or defer until later.
Co-authored-by: Andreas Braun <[email protected]>
Co-authored-by: Andreas Braun <[email protected]>
Co-authored-by: Andreas Braun <[email protected]>
Co-authored-by: Andreas Braun <[email protected]>
Co-authored-by: Andreas Braun <[email protected]>
Co-authored-by: Andreas Braun <[email protected]>
Co-authored-by: Andreas Braun <[email protected]>
Co-authored-by: Andreas Braun <[email protected]>
Co-authored-by: Andreas Braun <[email protected]>
Co-authored-by: Andreas Braun <[email protected]>
Co-authored-by: Andreas Braun <[email protected]>
Co-authored-by: Andreas Braun <[email protected]>
Co-authored-by: Andreas Braun <[email protected]>
git-sign
andgpg-sign
to use the file and environment variables created in setupmain
asv1
and call thisv2
.