feat(telemetry): report host_id for atlas COMPASS-8092 #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcasimir
approved these changes
Jul 26, 2024
There was a problem hiding this comment.
LGTM, left a couple of NIT comments. Couple of thoughts that came to mind while reviewing:
- can we add a test to make sure that we don't send this host id for non atlas connections? It would be quite bad if we start to send those
- I liked the idea of calling this prop
atlas_host_idas you did for the constant, instead ofhost_id, we can quickly ask in the analytics channel if they would be ok with it?
alenakhineika
added a commit
that referenced
this pull request
Aug 12, 2024
* fix: remove changelog from the bundle VSCODE-551 (#758) * Update changelog (#759) Co-authored-by: mcasimir <[email protected]> * Update changelog (#761) Co-authored-by: alenakhineika <[email protected]> * feat(telemetry): report host_id for atlas COMPASS-8092 (#763) * feat(telemetry): report host_id for atlas in VSCode COMPASS-8092 * test: add atlas host test and clean up * feat(telemetry): update new connection telemetry VSCODE-560 (#764) * feat(telemetry): update new connection telemetry VSCODE-560 * refactor: remove server_os * refactor: rename to atlas_hostname * docs: add comment * refactor(telemetry): use resolved srv from topology VSCODE-563 (#765) * Update changelog (#766) Co-authored-by: alenakhineika <[email protected]> * feat(telemetry): handle IPv6 addresses when parsing hostnames VSCODE-585 (#769) * feat(telemetry): handle IPv6 addresses when parsing hostnames VSCODE-585 * test: fallback to original uri * chore: reduce bundle size and add modules to externals * chore(deps): remove unused auto-prefixer (#771) * chore: use Node.js 20 in CI VSCODE-586 (#770) * chore: use Node.js 20 in CI VSCODE-586 * fix: try to resolve a regression of out of memory crashes of webpack --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: mcasimir <[email protected]> Co-authored-by: Rhys <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For every detected Atlas cluster track the first resolved hostname without the port when connecting.
Checklist
Motivation and Context
Types of changes