Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli-repl): prompt for password when redirecting output MONGOSH-1136 #2116

Merged
merged 6 commits into from
Aug 13, 2024
Merged

fix(cli-repl): prompt for password when redirecting output MONGOSH-1136 #2116

merged 6 commits into from
Aug 13, 2024

Conversation

mabaasit
Copy link
Contributor

@mabaasit mabaasit commented Aug 1, 2024

No description provided.

@mabaasit mabaasit marked this pull request as draft August 1, 2024 15:20
addaleax
addaleax approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feel free to add a test but this is probably just fine as it is as well

@mabaasit mabaasit marked this pull request as ready for review August 12, 2024 12:50
@mabaasit
Copy link
Contributor Author

@addaleax added in 2b676ee. Let me know if this looks good to you.

addaleax
addaleax approved these changes Aug 12, 2024
View reviewed changes
packages/cli-repl/src/run.spec.ts Outdated Show resolved Hide resolved
@mabaasit mabaasit merged commit f4448b0 into main Aug 13, 2024
67 of 71 checks passed
@mabaasit mabaasit deleted the MONGOSH-1136-prompt-for-password branch August 13, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mabaasit @addaleax