fix(node-runtime-worker-thread): remove function properties before serializing errors COMPASS-5919 #1762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failures seem unrelated, I'm putting the PR up for review |
gribnoysup
approved these changes
Nov 30, 2023
baileympearson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The structured cloning algorithm used by
postMessagedoesn't support functions. When invalid syntax is fed into the runtime-worker-thread for evaluation, mongosh returns a BabelParseError, which has aclone()method. This method causes the serialization of the error to fail and the incorrect error to be reported to Compass (see COMPASS-5919).This fix removes all function properties from Errors before serialization.
Below I've attached a screenshot showing this fix with a local build of Compass. The screenshot shows the same reproduction from COMPASS-5919, except that the syntax error is properly returned to Compass and rendered.
