chore: add a new “Startup Time” event for sessions MONGOSH-1653 #1761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anemy
reviewed
Nov 29, 2023
baileympearson
requested changes
Nov 30, 2023
Anemy
approved these changes
Nov 30, 2023
Comment on lines
+601
to
+617
| export const TimingCategories = { | ||
| REPLInstantiation: 'REPLInstantiation', | ||
| UserConfigLoading: 'UserConfigLoading', | ||
| DriverSetup: 'DriverSetup', | ||
| Logging: 'Logging', | ||
| SnippetLoading: 'SnippetLoading', | ||
| Snapshot: 'Snapshot', | ||
| ResourceFileLoading: 'ResourceFileLoading', | ||
| AsyncRewrite: 'AsyncRewrite', | ||
| Eval: 'Eval', | ||
| EvalFile: 'EvalFile', | ||
| Telemetry: 'Telemetry', | ||
| Main: 'Main', | ||
| } as const; | ||
|
|
||
| export type TimingCategory = | ||
| (typeof TimingCategories)[keyof typeof TimingCategories]; |
There was a problem hiding this comment.
Small nit, I think fine as is, we have other places in the code base with this pattern already. IIRC we try to avoid enums and rather use string literals in our code, so this would look like:
Suggested change
| export const TimingCategories = { | |
| REPLInstantiation: 'REPLInstantiation', | |
| UserConfigLoading: 'UserConfigLoading', | |
| DriverSetup: 'DriverSetup', | |
| Logging: 'Logging', | |
| SnippetLoading: 'SnippetLoading', | |
| Snapshot: 'Snapshot', | |
| ResourceFileLoading: 'ResourceFileLoading', | |
| AsyncRewrite: 'AsyncRewrite', | |
| Eval: 'Eval', | |
| EvalFile: 'EvalFile', | |
| Telemetry: 'Telemetry', | |
| Main: 'Main', | |
| } as const; | |
| export type TimingCategory = | |
| (typeof TimingCategories)[keyof typeof TimingCategories]; | |
| export type TimingCategory = | |
| | 'REPLInstantiation' | |
| | 'UserConfigLoading' | |
| | 'DriverSetup' | |
| | 'Logging' | |
| | 'SnippetLoading' | |
| | 'Snapshot' | |
| | 'ResourceFileLoading' | |
| | 'AsyncRewrite' | |
| | 'Eval' | |
| | 'EvalFile' | |
| | 'Telemetry' | |
| | 'Main'; |
There was a problem hiding this comment.
Yeah, this would have been a small nice-to-have :)
Co-authored-by: Bailey Pearson <[email protected]>
baileympearson
approved these changes
Nov 30, 2023
addaleax
reviewed
Dec 7, 2023
Comment on lines
+44
to
+45
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | ||
| for (const [category, _, time] of timingData) { |
There was a problem hiding this comment.
Also, just fyi:
Suggested change
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | |
| for (const [category, _, time] of timingData) { | |
| for (const [category,, time] of timingData) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.