-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): build kerberos in RTLD mode for Linux executables MONGOSH-1628 #1751
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -168,6 +168,10 @@ export class SignableCompiler { | |
// Custom env vars for sccache: | ||
AWS_ACCESS_KEY_ID: process.env.DEVTOOLS_CI_AWS_KEY, | ||
AWS_SECRET_ACCESS_KEY: process.env.DEVTOOLS_CI_AWS_SECRET, | ||
// https://jira.mongodb.org/browse/MONGOSH-1628 | ||
...(process.platform === 'linux' && { | ||
GYP_DEFINES: 'kerberos_use_rtld=true', | ||
}), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ^ This + the version bump are the entire fix, the rest is just testing/cleanup :) |
||
}, | ||
addons: [fleAddon, osDnsAddon, kerberosAddon, cryptLibraryVersionAddon] | ||
.concat(winCAAddon ? [winCAAddon] : []) | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,10 +11,16 @@ mkdir -p "$TEST_TMPDIR" | |
cd "$TEST_TMPDIR" | ||
export TEST_TMPDIR="$PWD" | ||
|
||
if [[ -z "$TEST_MONGOSH_EXECUTABLE" ]]; then | ||
export MONGOSH=mongosh | ||
else | ||
export MONGOSH="${MONGOSH_ROOT_DIR}/${TEST_MONGOSH_EXECUTABLE}" | ||
fi | ||
|
||
git clone [email protected]:mongodb-js/devtools-docker-test-envs.git test-envs | ||
cd test-envs | ||
|
||
git checkout f029f9e3a9cc006a6aeb60d941b4f8d87ae4bc95 | ||
git checkout ca4bacd23e6f7ea07618c303b20556e3e4c9c2e6 | ||
|
||
"$CONNECTIVITY_TEST_SOURCE_DIR/ldap.sh" | ||
"$CONNECTIVITY_TEST_SOURCE_DIR/localhost.sh" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Kerberos system libraries are no longer strictly a dependency for mongosh)