Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: run cross-env with npx in bootstrap #1724

Merged
merged 1 commit into from
Nov 8, 2023
Merged

chore: run cross-env with npx in bootstrap #1724

merged 1 commit into from
Nov 8, 2023

Conversation

gribnoysup
Copy link
Contributor

Otherwise you need to run install before you run install making this command a bit unhelpful

lerouxb
lerouxb approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@lerouxb lerouxb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this was missed by me when I removed prebootstrap which just ran npm install which would itself just make PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=1 useless because it would have already installed puppeteer anyway ;)

@gribnoysup gribnoysup merged commit 7362f7a into main Nov 8, 2023
2 checks passed
@gribnoysup gribnoysup deleted the do-not-require-install-before-bootstrap branch November 8, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@lerouxb lerouxb lerouxb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gribnoysup @lerouxb @addaleax