-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade driver and bson to 5.0 MONGOSH-1358 #1403
Conversation
These are no longer supported by the driver, and will only become useful once full driver logging is implemented.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good! Left a few comments here and there
Just for context, we should wait for https://jira.mongodb.org/browse/NODE-5052 and probably other tickets from https://jira.mongodb.org/issues/?jql=labels%20%3D%20node-v5-support to be resolved before merging this. |
At least locally Java tests fail with
I will take a look on Monday |
@kornilova203 Just fyi, we’re looking to publish a new release with the changes here, so we’ll probably merge this tomorrow unless that seems like a bad idea to you – the java-shell tests do seem to pass just fine in CI |
@addaleax, now tests pass on my machine too :) don't know what was the problem |
(see also https://docs.google.com/document/d/1k0Ow5fd9bouBwboPzUisGN8lvP4YviNzDY4y2aI_TRQ/edit#)
chore: make --quiet and --verbose no-ops
These are no longer supported by the driver, and will only become
useful once full driver logging is implemented.
chore: remove unused and deprecated .remove() method from service providers
chore(cli-repl): display write errors as separate error category
chore: update mocks in tests for TS updates
chore(shell-api): start sharding test setup with --csrs
feat: update Shell BSON code for BSON v5 upgrade
feat: upgrade driver and bson to 5.0.0
chore(deps): bump mongodb-client-encryption to 2.5.0
chore: switch java-shell to webpack, adjust for bson v5
chore(deps): bump mongodb-log-writer to 1.1.5
chore: update shell bson printing code for bson 5