Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shell-api): add convertShardKeyToHashed() MONGOSH-1050 #1364

Merged
merged 3 commits into from
Nov 30, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/cli-repl/test/e2e.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -523,6 +523,13 @@ describe('e2e', function() {
expect(await shell.executeLine('typeof JSON.parse(JSON.stringify(db.test.insertOne({}))).insertedId')).to.include('string');
});

context('post-4.2', () => {
skipIfServerVersion(testServer, '< 4.4');
it('allows calling convertShardKeyToHashed() as a global function', async function() {
expect(await shell.executeLine('convertShardKeyToHashed({foo:"bar"})')).to.include('Long("4975617422686807705")');
});
});

describe('document validation errors', () => {
context('post-4.4', () => {
skipIfServerVersion(testServer, '<= 4.4');
Expand Down
4 changes: 3 additions & 1 deletion packages/connectivity-tests/test/atlas.sh
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,9 @@ fi

FAILED=no

CONNECTION_STATUS_COMMAND='db.runCommand({ connectionStatus: 1 }).authInfo.authenticatedUsers'
# convertShardKeyToHashed() may seem weird to include here, but it's the best
# way to make sure that it works in our standard environments we connect to
CONNECTION_STATUS_COMMAND='convertShardKeyToHashed("asdf");db.runCommand({ connectionStatus: 1 }).authInfo.authenticatedUsers'
CONNECTION_STATUS_CHECK_STRING="user: '${ATLAS_USERNAME}'"

function check_failed() {
Expand Down
8 changes: 8 additions & 0 deletions packages/i18n/src/locales/en_US.ts
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,10 @@ const translations: Catalog = {
},
isInteractive: {
description: 'Returns whether the shell will enter or has entered interactive mode'
},
convertShardKeyToHashed: {
description: 'Returns the hashed value for the input using the same hashing function as a hashed index.',
link: 'https://www.mongodb.com/docs/manual/reference/method/convertShardKeyToHashed/'
}
}
},
Expand Down Expand Up @@ -1798,6 +1802,10 @@ const translations: Catalog = {
getClientEncryption: {
description: 'Returns the ClientEncryption object for the current database collection. The ClientEncryption object supports explicit (manual) encryption and decryption of field values for Client-Side field level encryption.',
link: 'https://docs.mongodb.com/manual/reference/method/getClientEncryption/#getClientEncryption'
},
convertShardKeyToHashed: {
description: 'Returns the hashed value for the input using the same hashing function as a hashed index.',
link: 'https://www.mongodb.com/docs/manual/reference/method/convertShardKeyToHashed/'
}
}
},
Expand Down
9 changes: 9 additions & 0 deletions packages/shell-api/src/integration.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2047,6 +2047,15 @@ describe('Shell API (integration)', function() {
}
});
});
describe('convertShardKeyToHashed', () => {
skipIfServerVersion(testServer, '< 4.4');

it('converts a shard key to its hashed representation', async() => {
const result = await mongo.convertShardKeyToHashed({ foo: 'bar' });
expect(result.constructor.name).to.equal('Long');
expect(result.toString()).to.equal('4975617422686807705');
});
});
});
describe('PlanCache', () => {
skipIfApiStrict();
Expand Down
29 changes: 29 additions & 0 deletions packages/shell-api/src/mongo.ts
Original file line number Diff line number Diff line change
Expand Up @@ -667,4 +667,33 @@ export default class Mongo extends ShellApiClass {
}
return this._keyVault;
}

@returnsPromise
async convertShardKeyToHashed(value: any): Promise<unknown> {
const pipeline = [
{ $limit: 1 },
{ $project: { _id: { $toHashedIndexKey: { $literal: value } } } }
];
let result;
try {
// Try $documents if available.
result = await (await this.getDB('admin').aggregate([ { $documents: [{}] }, ...pipeline ])).next();
} catch {
try {
// If that fails, try a default collection like admin.system.version.
result = await (await this.getDB('admin').getCollection('system.version').aggregate(pipeline)).next();
} catch {
// If that fails, try using $collStats for local.oplog.rs.
try {
result = await (await this.getDB('local').getCollection('oplog.rs').aggregate([ { $collStats: {} }, ...pipeline ])).next();
} catch { /* throw exception below */ }
}
}
if (!result) {
throw new MongoshRuntimeError(
'Could not find a suitable way to run convertShardKeyToHashed() -- tried $documents and aggregating on admin.system.version and local.oplog.rs',
CommonErrors.CommandFailed);
}
return result._id;
}
}
5 changes: 5 additions & 0 deletions packages/shell-api/src/shell-api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -316,6 +316,11 @@ export default class ShellApi extends ShellApiClass {
await this._print(origArgs, 'printjson');
}

@returnsPromise
async convertShardKeyToHashed(value: any): Promise<unknown> {
return this._instanceState.currentDb._mongo.convertShardKeyToHashed(value);
}

@directShellCommand
@returnsPromise
async cls(): Promise<void> {
Expand Down