fix(logging): keep userId for old and new users MONGOSH-1143 #1229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Mar 14, 2022
|
Yeah already on it, wrong node/npm locally. |
alenakhineika
deleted the
MONGOSH-1143-keep-user-id-for-old-and-new-users
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to keep
userIdfor old and new users as well for backward compatibility with the oldermongoshversions. If a user installed a newer version first, with code that is currently inmainonlyanonymousIdwill be saved to a new config file. If the user then downgrades the version and tries to runmongosh, they will get theAssertionError: You must pass either an "anonymousId" or a "userId".error, because the config file stores onlyanonymousId, but the older version ofmongoshdoesn't know what it is and needsuserIdfor telemetry.